search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.17k forks source link

"Hates vegetables" makes you hate things that aren't vegetables #60241

Open Kiael opened 2 years ago

Kiael commented 2 years ago

Describe the bug

Rice and beans are both not vegetables, but because they are plant matter you will get an allergic reaction from anything made from either if you have "Hates Vegetables." Beans you could argue is an earthy flavor that someone who hates vegetables might also hate, but that seems like kind of an assumption.

Steps to reproduce

  1. Try to eat something made of rice or beans while you hate vegetables.
  2. Suffer

Expected behavior

You should definitely be able to eat rice, and arguably beans as well if you hate vegetables.

Screenshots

No response

Versions and configuration

Game Version: 07d8e66

Additional context

none

Marcos6226 commented 2 years ago

This could be resolved by either creating a grain id on materials.json and change every grains that is classified as vegetables or change the way "Hates vegetables" trait works.

Zireael07 commented 2 years ago

IIRC this is a very long-standing issue, likely to already be reported somewhere in the giant tracker, but it's good to have it visible again

ZeroInternalReflection commented 2 years ago

There was some discussion of this on the development Discord when I was testing #59914. There's a bit of a disconnect between saying a character "Hates vegetables" and the in-game implementation of "this character has an allergic reaction/digestive issue upon consuming any plant matter". I believe the trait needs to exist in its current iteration for certain mutation paths, but should probably be renamed to clarify that it's a physical issue rather than a psychological one, and that it doesn't just apply to what might be considered a "vegetable".

Also, given the rather amorphous definition of a "vegetable", additional granularity on vegetable vs. fruit. vs. grain. vs. etc. will probably be... complicated. I agree it would be beneficial for many things, but it's not going to be without debate.

Kiael commented 2 years ago

There was some discussion of this on the development Discord when I was testing #59914. There's a bit of a disconnect between saying a character "Hates vegetables" and the in-game implementation of "this character has an allergic reaction/digestive issue upon consuming any plant matter". I believe the trait needs to exist in its current iteration for certain mutation paths, but should probably be renamed to clarify that it's a physical issue rather than a psychological one, and that it doesn't just apply to what might be considered a "vegetable".

Also, given the rather amorphous definition of a "vegetable", additional granularity on vegetable vs. fruit. vs. grain. vs. etc. will probably be... complicated. I agree it would be beneficial for many things, but it's not going to be without debate.

If its the case that its filling in the "general mutated carnivore and rare genetic allergy that can maybe eat fruits" goal then I understand why beans are something that the character is allergic to, but I think some of the carbohydrate type restrictions are arbitrary. Why can carnivores eat flour, but not rice flour? Cornmeal I can get the restriction as it is a different category, and to an extent oatmeal as well. Its telling that cat food which is intended for what is mostly a strict carnivore is often fortified with simple carbs from sources like corn or rice or wheat. Either "Hates vegetables" or whatever the trait is going to be renamed needs to not have the option of consuming flour, or it needs to also have the option of consuming rice flour in my opinion, the current implementation isn't consistent.

Marcos6226 commented 2 years ago

If its the case that its filling in the "general mutated carnivore and rare genetic allergy that can maybe eat fruits" goal then I understand why beans are something that the character is allergic to, but I think some of the carbohydrate type restrictions are arbitrary. Why can carnivores eat flour, but not rice flour? Cornmeal I can get the restriction as it is a different category, and to an extent oatmeal as well. Its telling that cat food which is intended for what is mostly a strict carnivore is often fortified with simple carbs from sources like corn or rice or wheat. Either "Hates vegetables" or whatever the trait is going to be renamed needs to not have the option of consuming flour, or it needs to also have the option of consuming rice flour in my opinion, the current implementation isn't consistent.

What do you think about renaming it to "vegetable intolerance" or something similar, but keeping its functions the same? Or alternatively, we could merge the fruit intolerance into hates vegetables and call it cellulose intolerance.

hexagonrecursion commented 2 years ago

/confirmed

What about renaming it to "plant matter intolerance"?