CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.59k stars 4.16k forks source link

Increase amount of craftables in chemistry and fix recipes #60803

Closed borsek closed 1 year ago

borsek commented 2 years ago

Is your feature request related to a problem? Please describe.

Currently the state of chemistry crafts in CDDA is somewhat lacking:

I haven't combed through every nonsensical recipe, be it time or ingredients, but it irks me. So much could be done, we have so many chemicals and locations which provide all the tools necessary for complex chemical synthesis, yet we can do less (and slower) than a crackhead in an RV in the Nevada desert.

Are any of these as they are for some balancing purposes, or did no one get around to fixing/changing them?

Solution you would like.

Fixed and expanded recipes.

Describe alternatives you have considered.

Focusing on life and work instead of CDDA.

Additional context

Can help, am chemist.

Terrorforge commented 2 years ago

It's mostly just that very few of us have the expertise. The only reason you're not finding anhydrous ammonia in cleaning cupboards any more is that a different chemist(try nerd?) had the same reaction and went berserk on the files. But as you've noticed, there's still much to do.

It is mostly .json work, so you could probably do a lot of it yourself if you wanted to. Check out CONTRIBUTING.md for more on that

But if you poke your head into the Discord, or maybe just get lucky with a passing dev spotting this, I'm sure you can find someone who's willing to work on the code side of things if you can provide the necessary expertise to come up with and balance the recipes correctly.

borsek commented 2 years ago

Sounds good, I'm not much of a coder, but I've messed with .json data on my end already (added the ASRG as a vehicle power source for my 30-ton... tank?). It'll take me a bit to get into github PR/editing, but I'd gladly add to them myself, just don't want to step on any toes or work on stuff that is in the middle of an overhaul.

Should probably join the discord too, aye.

robotic-gamer commented 2 years ago

I have a few suggestions myself:

Daved27hundred commented 1 year ago

I've got some coding knowhow and I'm interested in helping, specifically with chemicals that have little to no use ingame. Phenol, acrymalide, toluene and nickel powder all do nothing (though those last two are used to make sedatives, but nothing else) and I was looking for something I could do with them. My chemistry knowledge is too basic to know how to apply them, so I was wondering if you could lend a hand in that department.

kevingranade commented 1 year ago

The things outlined in the topic post seem reasonable for the most part (note that "making nitrocellulose" and "making nitrocellulise you can use to reload a firearm cartridge and not expect bad things to happen" are two different things).

However, this is what is referred to as an omnibus issue, which causes problems in the future if/when parts of the issue start being implemented. Issues need to work toward a concrete and achievable goal, not list disparate content additions. As you can see in the comments, this kind of issue has a tendency to grow over time instead of being resolved.

Feel free to open individual targeted issues covering the topics you mentioned here.