CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Cutting up makeshift bandages (crafted from 1 cotton patch) can be cut up to get multiple cotton patches #61566

Closed FlyingSpaceRhino closed 1 year ago

FlyingSpaceRhino commented 2 years ago

Describe the bug

A player can create multiple cotton patches from a single cotton patch, as long as the player mentally thinks of it as a bandage before cutting it up.

Steps to reproduce

  1. Craft makeshift bandage using 1 cotton patch
  2. "Cut up" the makeshift bandage
  3. You will get usually get 11 to 14 cotton patches from what was once 1.

Expected behavior

Makeshift bandages should not break the laws of conservation of mass. Should only get 1 cotton patch.

Maybe remove the ability to cut them up, instead being able to disassemble them to return the single cotton patch.

Screenshots

Screenshot (457)

Versions and configuration

Additional context

No response

actually-a-cat commented 2 years ago

This is because cotton patches used to be larger (back when they were called rags)

I think the correct solution would be to craft makeshift bandages from cotton sheets instead, and align their size/weight with them (it's already kinda close)

FlyingSpaceRhino commented 2 years ago

I've found that this also happens with "antiseptic soaked rag", so this issue likely exists for other similar items as well. Screenshot (471)

strategineer commented 1 year ago

Seems like this original issue has been resolved by https://github.com/CleverRaven/Cataclysm-DDA/pull/61992 specifically (https://github.com/CleverRaven/Cataclysm-DDA/pull/61992/files#diff-1c83fa5000d8e5c822831984469aaf9b1474d581da3e5752f70920524e42678e and https://github.com/CleverRaven/Cataclysm-DDA/pull/61992/files#diff-05b491d0da1a090113a035ee9106f0ab73b0206e63b457872f83fd66b7b0a235).

But it seems like rags are in a bit of a weird place right now https://github.com/CleverRaven/Cataclysm-DDA/pull/54256/files#diff-975fd9112243b1d868c6e2e244be9e1a1154ab1f0ded33c00b0d75b39c1b31a4R140