CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Noise threshold customizing breaks mapgen? #61758

Closed NetSysFire closed 2 years ago

NetSysFire commented 2 years ago

Describe the bug

I am playing around with the default region settings, aiming to reduce thick forest and having more sparse ones.

    "overmap_forest_settings": {
      "noise_threshold_forest": 0.2,
      "noise_threshold_forest_thick": 0.4,
      "noise_threshold_swamp_adjacent_water": 0.3,
      "noise_threshold_swamp_isolated": 0.99,
      "river_floodplain_buffer_distance_min": 3,
      "river_floodplain_buffer_distance_max": 15
    }

image

As you can see, my character is currently in thick forest, according to the map. The thick forest is not even generated though:

image

With these settings, all of the thick forest I could find are just fields. I do not know if this is a bug or if I am doing something wrong, since these settings are not well documented.

Steps to reproduce

  1. Use the region settings I use.
  2. Teleport to the nearest forest_thick terrain.
  3. Witness the wasteland.

Expected behavior

There being thick forest. These are most definitely fields in disguise.

Screenshots

No response

Versions and configuration

Additional context

Edit: It broke swamps, too and I only messed with the isolated swamp setting aaaaaaaa

NetSysFire commented 2 years ago

Closing as user error. The noise is not responsible. It was because I only had forest defined in forest_mapgen_settings. forest is mandatory, but forest_thick and forest_water is not. Imo it should be mandatory unless its noise threshold is 1. It is inconsistent because everything else needs to be properly declared and defined.