Leftovers from the MBR vest era still haunt the game.

[Daved27hundred]

Describe the bug

Anyone remember MBR vests? those odd ballistic vests we had back when ballistic damage was registered as cut damage? The game apparently still does even though they were removed in #36920 (TWO YEARS ago) because we still have the armor plates that were meant to go inside that vest ingame, specifically the steel plate, the hard steel plate, and the ceramic armor plate.

The descriptions of these items still says they can be slid into a bullet resistant vest - despite not only being unable to fit into any of them. These things predate the ESAPI ballistic vests we have right now as well as predating nested containers, so they were fit into a vest with the crafting menu back then.

This wouldn't be much of an issue if they did not spawn ingame, but they do, and the steel plate even kept it's crafting recipe. New players who find these will be confused when they don't fit in their vests in their vests like the description says.

Steps to reproduce

1. Spawn the three plates
2. Spawn an ESAPI vest
3. Attempt to insert the plates into your ESAPI vest, which you cannot do.

Expected behavior

These things should probably have their descriptions changed, be obsoleted, or even repurposed to actually work. I would prefer them be obsoleted but the plates will need the correct flags and protection values if someone intends to make them useful.

Screenshots

ceramic armor plate. notice the description, which is a lie. example of the plate showing up ingame, dropped by a robot. steel plate's recipe still existing, visible on the HHG.

Versions and configuration

• OS: Windows 10 Version 1909
• Game Version: 300ec6d Experimental build 2022-11-01-0509
• Graphics Version: Tiles
• Ingame Language: English
• Mods loaded: [ Dark Days Ahead [dda], No fungal growth [no_fungal_growth, No rail stations [no_rail_stations]. ]

Additional context

No response

[RenechCDDA]

/confirmed

Ceramic plates from drops should be migrated to broken ceramics. Ceramics found in old lab storage (thus, pristine) should be migrated to existing front/side plates. Steel plate recipe should obsoleted/migrated to scrap ESBI/ESAPI plate. Hard steel plate should probably just be obsoleted and removed from drop tables. edit: Hard steel plate should probably be migrated to heavy steel ballistic plate with some amount of damage.

[Daved27hundred]

all three descriptions need to be changed, as well. remember that, whoever tackles this.

[reusityback]

Ceramic plates from drops should be migrated to broken ceramics. Ceramics found in old lab storage (thus, pristine) should be migrated to existing front/side plates.

What do you mean by broken ceramics? Compromised ones?

[RenechCDDA]

What do you mean by broken ceramics? Compromised ones?

id ceramic_armor should migrate to destroyed_large_ceramic_plate