CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Cannot insert solid fuel into bionic fuel containers (affects mods) #62617

Closed AmarinReyny closed 1 year ago

AmarinReyny commented 1 year ago

Describe the bug

So, as described here, there are some issues with the way solid fuel is handled by bionic fuel containers - specifically, there is no way to insert solid fuel into said containers. They can't be reloaded, trying to insert the fuel from the inventory menu doesn't work, etc..

Steps to reproduce

  1. Use a mod that adds a bionic that turns solid fuels into electricity
  2. Try to load said fuel into the bionic's fuel container
  3. Witness that you cannot

Expected behavior

I expect fuel containers to work just as well with solid fuels as they do with liquid fuels and batteries.

Screenshots

No response

Versions and configuration

Additional context

I know that I'm experiencing this problem with content from a non-mainlined mod, but given that we've tried making the mod work on that end, and ended up realizing that A. we can't make it work even with making sure that the bionics'/containers' code matches up perfectly with their vanilla counterparts, B. there otherwise is no indication that the problem comes from the mod itself, we think it's pretty safe to say that there's something wrong with the way the game handles solid bionic fuel. This would also mean that this problem will effect not just Arcana, but any mod, or even future vanilla content, that adds in bionics/containers meant to use solid fuels.

EDIT: Just to be clear, the bionic fuel containers are coded in a way that matches the way bionics now work in vanilla to a t. They still don't work.

Hirmuolio commented 1 year ago

I found the problem. There is weird check in reloading code that allows reloading CONTAINER type pockets only with liquids. This is most likely to make it more convenient to reload bottles with drinks.

You can use the insert method instead. Look at the fuel tank and select (i)insert item. There you can put the essence in. Maybe best would be to turn essence into ammo type and the fuel storage pocket into magazine so they can be easily reloaded.

If you still don't get any energy you may also need to disable fuel saving mode. Single charge of essence has 1200 kJ of energy and fuel saving mode will try to not waste it.

AmarinReyny commented 1 year ago

You can use the insert method instead. Look at the fuel tank and select (i)insert item. There you can put the essence in.

Already tried the insert method. It didn't work.

You may also need to disable fuel saving mode. Single charge of essence has 1200 kJ of energy and fuel saving mode will try to not waste it.

That'd be something to worry about if and when we finally manage to get any essence into the fuel tank.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.