search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.32k stars 4.14k forks source link

Throwing accuracy in the sidebar does not seem to account for throwing skill. #64265

Open Aerin-of-the-Toast opened 1 year ago

Aerin-of-the-Toast commented 1 year ago

Describe the bug

When throwing at enemies with some level of throwing skill, the sidebar lists hit chances in the low single-digits despite actual testing hitting almost 90% of the time. This does not seem to apply at 0 throwing, where you do miss about as often as the sidebar indicates. The problem exacerbates at higher levels. It seems the sidebar accuracy might not be taking throwing skill into account.

Attach save file

N/A

Steps to reproduce

  1. Spawn a debug monster some distance away (5-10 tiles works).
  2. Spawn a bunch of rocks. Wield them and set their hotkey to 't' to speed up testing.
  3. Set display style to "numbers" instead of "bars" in the options menu for a more accurate readout.
  4. With throwing skill at 0, aim a throw. Note the hit chance is only around 3-4%, with 95% miss chance.
  5. Throw a bunch of rocks, note that almost all miss.
  6. Set throwing skill higher, e.g. around 4.
  7. Aim a throw: note the hit chance has barely changed.
  8. Throw a bunch of rocks: note that you're now hitting the majority of your rocks.
  9. Set throwing to 10.
  10. Aim: Note hit chance is still showing the same values as throwing skill 0.
  11. Throw a bunch of rocks, note that you're now almost always getting regular or good hits.

Expected behavior

I expect the hit chance readout to give an accurate representation of my chance to hit.

Screenshots

My listed chance to hit (at 10 throwing) image The result of 10 thrown rocks. image

Versions and configuration

Additional context

No response

Termineitor244 commented 1 year ago

/confirmed.

SurFlurer commented 1 year ago

The behavior changed between https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/cdda-experimental-2022-07-15-1818 and https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/cdda-experimental-2022-07-31-0049.

It seems that #59512 introduced this.