search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.66k stars 4.18k forks source link

How is it that wearing a bra inside a T-shirt would result in 2 encumbrance ? #65145

Open Proxima-b opened 1 year ago

Proxima-b commented 1 year ago

Describe the bug

Currently wearing a bra inside a T-shirt would result in 2 encumbrance because they both occupy the same layer of clothing. However that not always the case IRL, NOT wearing a bra or some sort of close fit garment would result in some kind of encumbrance upon certain activities, at lease for most women that is. I think an "underwear" layer should be added to address this issue.

Attach save file

N/A

Steps to reproduce

  1. Make a female character
  2. See that the bra causes extra encumbrance

Expected behavior

An extra underwear layer for bra and bikini items. Or Some sort of negative encumbrance to offset the effect.

Screenshots

No response

Versions and configuration

latest stable

Additional context

No response

fairyarmadillo commented 1 year ago

Close to skin is already the underwear layer. This issue popped up because someone decided to make t-shirts underwear.

Underwear probably now needs a flag to prevent it from conflicting with non-underwear items on the same layer.

John-Candlebury commented 1 year ago

Tshirts and other shirts, at least the not skinny ones, should be normal layer.

fairyarmadillo commented 1 year ago

Tshirts and other shirts, at least the not skinny ones, should be normal layer.

See this PR for details on why they aren't. I agree in principle but it causes other problems.

hexagonrecursion commented 1 year ago

/confirmed duplicate #61634

SeanMirrsen commented 1 year ago

Why not do some fuzzy logic on intersecting coverage versus encumbrance?

Let's take an extreme example, a belt or strap. A single belt or strap covers like 5% of the layer it's on, but wearing multiple of them would increase encumbrance when it... probably really shouldn't, given that they can cover different 5% of the layer each.

Obviously there's considerations of flexibility and whatnot, but within some generous margin a couple items and accessories occupying the same layer/bodypart won't meaningfully restrict movement.

So maybe have it where low-coverage items on the same layer have a reduced effect on the encumbrance penalty? I'm not sure exactly how wide to draw the margins, it will probably need tuning to account for edge cases, but broadly it should be made to account for the case of bra vs t-shirt, and go from there.

estebandellasilva commented 1 year ago

Treat bras and panties the same as Cat Ears + Tails