search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

UI incorrectly reports solar panels as cause of slow movement when walking in vehicle #65221

Open GlitterLich opened 1 year ago

GlitterLich commented 1 year ago

Describe the bug

On a vehicle tile consisting of only a frame, a roof and a solar panel, the UI's log will report "Moving onto/off this solar panel is slow!", whereas the actual cause of slowdown is the naked frame sitting underneath it.

Attach save file

N/A

Steps to reproduce

  1. Make a vehicle tile consisting of only a frame, a roof and a solar panel
  2. Walk on/off it

Expected behavior

The UI should properly report that "Moving onto/off this frame is slow!" instead.

Screenshots

N/A

Versions and configuration

Windows 7 64bit 0.G stable

Additional context

No response

RenechCDDA commented 1 year ago

Confirmed, and yes this could be more accurate with information given to the player. Right now it's just pulling the display part, which is why solar panels and not roofs trigger it. (The roof is actually unnecessary and doesn't interact in any way)

https://github.com/CleverRaven/Cataclysm-DDA/blob/a2f5875d92995cba39653f3c15a0b2d396258b37/src/game.cpp#L10305-L10311