CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.54k stars 4.16k forks source link

Hub 01 Bar punctuation issues and apricots #65911

Closed sadenar closed 1 year ago

sadenar commented 1 year ago

Describe the bug

During the long trundle of translation, I spotted a number of punctuation inconsistencies in the hub 01 bar dialogue which I'll list here as well as the needed fix, it's mostly missing periods/extra punctuation marks:

I'm less sure of the following three since they seem to be written prompts of actions rather than dialogue, so not sure if they should have punctuation, but some similar descriptions of actions in this dialogue section do?

Additionally, completely unrelated aside from the fact that I found these issues at roughly the same time, and this is the reason I added apricots in the title, the description and item name of "handful of irradiated apricots" is inconsistent as it is the following:

The description should probably be changed to refer to multiple apricots just like the description of the regular handful of apricots.

Attach save file

N/A

Steps to reproduce

  1. For the dialogue:
  2. Talk to the people in the Ancilla bar
  3. Look at the dialogue for the listed typos
  4. For the apricots:
  5. Irradiate apricots

Expected behavior

Expected behavior for all of this is for there to be no typos

Screenshots

No response

Versions and configuration

Typos spotted on Transifex, so in game as of latest experimental

Additional context

No response

Procyonae commented 1 year ago

Unless they're purposefully talking weird or I'm missing the context I'd suggest the grammatical adjustments of: Sorry I rather be left alone right now. -> Sorry, I'd rather be left alone right now. Sure, let see what you offer. -> Sure, let's see what you have to offer.

Also the anchor one is missing an apostrophe though I'd suggest that "We have a deal?" sounds better regardless (And probably makes more sense to translators). Take the anchor and leave the coin. Its a deal? -> Take the anchor and leave the coin. It's a deal?

sadenar commented 1 year ago

Adding three more I found since then to the bag, we have:

Starting location Clothing Store is typo'd:

A swear sentence for danger elevation probably has improper capitalization:

Simple missing period on a return to safety NPC statement:

sadenar commented 1 year ago

Another five to the stack:

Caviar and egg sandwich does not seem to have a plural, as in for the plural form it should be changed this way:

Windmill construction task description is missing a period while all building task descriptions I've seen so far do:

Bird bath + bench task desc is also missing a period:

Brewery rack desc also missing a period:

This desc is also missing a period:

sadenar commented 1 year ago

Some camp dialogue string's translation context mentions a third component that is not present in the string, this specific string from what I gather is to give potential faction camp locations when NPCs are asked about it:

Misspelt don't in what I assume is a monster snippet for some kind of nether monster? Might be shadows since their attack text is just above in transifex, but unsure:

sadenar commented 1 year ago

Another one, depends on whether Valhallists ever get unobsoleted, but if they do, this needs fixing:

In godco dialogue:

Procyonae commented 1 year ago

The screenshotted one is to do with something temporarily commented out in the C++ so I'm gonna leave it alone but the rest of the fixes are on the way ^^