CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.59k stars 4.16k forks source link

Add poppy seeds to be able to plant poppies #66191

Closed Michael1993 closed 1 year ago

Michael1993 commented 1 year ago

Is your feature request related to a problem? Please describe.

I would like to grow poppies - we can grow all the other plants, why not poppies as well?

Solution you would like.

Just add a poppy seed recipe and a poppy seed growable. Should be easy?

Describe alternatives you have considered.

Not sure if poppies are somehow special because they only exist in mutated form.

Additional context

No response

RenechCDDA commented 1 year ago

Note that the only poppies we have ingame are some weird mutated ones, which don't necessarily correspond to normal growing patterns.

@NetSysFire was recently discussing in the CDDA IRC their desire (plan?) to add normal poppies and some interactions with the existing mutated poppies.

So this suggestion might be closer than you imagine :)

Michael1993 commented 1 year ago

I'd be happy to attempt this - it should just be another normal plant, right?

NetSysFire commented 1 year ago

I actually have worked on that, yes. But if you want to fiddle around with it, go ahead and use what I have already typed out. I pushed my incomplete changes (https://github.com/NetSysFire/Cataclysm-DDA/commit/7b66fb93dc6eddfc76eebd7f5cbe94416b103a46) for you, which were actually intended to be used to address #53264.

My plan was to add normal opium poppies, which you can plant and use. According to my research, you shouldnt find opium poppies in the wild (see also https://gobotany.nativeplanttrust.org/species/papaver/somniferum/), maybe ideally in some gardens and maybe moonshine stills (basically maybe another variant for an implied drug den?) or collapsed sheds or so.

I am still unsure whether or not I should make mutated poppies drop more buds or a type of poppy bud that counts as multiple normal poppy buds. The devil is in the details.

Michael1993 commented 1 year ago

I've looked at your draft and am seeking feedback before taking a crack at a small PR. Alternatives I've considered:

Either way I would be adding some poppy seed recipes (e.g.: ground them up for poppy seed muffin, poppy seed cake, press them for vegetable oil, maybe opium production (depending on how complicated it is))

NetSysFire commented 1 year ago

Poppy seed recipes are a good idea. I just wanted to address the fact that all poppy flowers mysteriously mutated and not one was left out.

moving the (non-mutated) poppy definition to only be growable

I intended the normal poppies to be found more often than the mutated variants and plantable normally. The mutated variants, however should not be able to grown just like that I think. Or lock the recipe for plantable mutated poppy seeds behind a quest, there is a NPC at the refugee center which is also interested in mushroom samples iirc, a mutated poppy seed quest would fit in there perfectly. The latter is the preferred solution to me, but that will mean more effort.

You might also want to make mutated poppies drop poppy seed with higher opiod percentage but they also have toxins. However, there is currently a hardcoded function for poppy harvesting, but adding another drop should be super basic C++ that even I would be able to do. Poppies also drop their bud regardless of season, which is odd, due to this hardcoded function.

https://github.com/CleverRaven/Cataclysm-DDA/blob/bf78e46b2ad0dde8048753d3ea70337bb2b88af5/src/iexamine.cpp#L2169-L2222

I am currently unexpectedly busy irl due to several reasons and if you would like to take this work off my shoulders, I gladly accept.

PatrikLundell commented 1 year ago

Note that the refugee center character doesn't actually generate a proper quest, but rather the kind of trade arrangement that some other characters produce. Also, she's recruitable, which can complicate things, and is a mycologist which means I'm not sure how relevant mutated poppies would be.

Tharn commented 1 year ago

Regular poppy is a good idea. Making the mutated version farmable opens up a problem because mutated poppy products rival the prescription meds in strength.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.