CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.1k stars 4.1k forks source link

The ability to have unlimited engines in a vehicle if they don't drive the wheels #66695

Closed anoobindisguise closed 11 months ago

anoobindisguise commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently there is a hard limit on the number of engines per vehicle (1 normally or 2 if you're a master mechanic) but this isn't a realistic limit as you could easily have disconnected engines in the vehicle purely to generate power.

Solution you would like.

Engine installation should probably be able to determine which wheels the engine drives, which would be extremely complicated but allow for things like individual engines per wheel as is the case for some IRL vehicles. The simplest solution though would be a binary "provides/doesn't provide motive power" flag on the engine upon installation.

Describe alternatives you have considered.

Like above a more comprehensive system of "what engine drives what wheel if any" would be good to have but it would be terribly complicated and probably not necessary. The current system of all cars being 4WD isn't totally realistic but it's "good enough".

Additional context

Vehicle code is terrifying

MNG-cataclysm commented 1 year ago

Why do we have a hard cap of engines, anyways? What's stopping someone from adding as many engines as they want to and making an ultra-powerful car?

KHeket commented 1 year ago

In reality we have the example of multiple engines on the working vehicle https://en.wikipedia.org/wiki/BelAZ_75710 So, its have 2 electricity generators connected to 1 diesel engine, and its construction is generating power for 4 electric motors, two at each axel, I dont know, is there any other exampleof such conctruction. and can you make this for regular car, but in theory you can do it image

MNG-cataclysm commented 1 year ago

We could just remove the artificial hard cap on engine limits as a result of this. Yes, you would have an ultra-powerful vehicle, but it'd bird through gas like nothing, making it a natural regulating limit to vehicle power.

randomtyper commented 1 year ago

In reality we have the example of multiple engines on the working vehicle https://en.wikipedia.org/wiki/BelAZ_75710 So, its have 2 electricity generators connected to 1 diesel engine, and its construction is generating power for 4 electric motors, two at each axel, I dont know, is there any other exampleof such conctruction. and can you make this for regular car, but in theory you can do it image

I see this, and raise you this https://en.wikipedia.org/wiki/ZIL-135 (two engines, each driving wheels on their side and not their axis, should have logically had problems with asymmetric power, but actually worked well for its purposes) and this https://en.wikipedia.org/wiki/Chrysler_A57_multibank (five engines cobbled into one, used on Shermans).

So... I think lifting the limit for some time would be a decent bandaid.

SurFlurer commented 1 year ago

We could just remove the artificial hard cap on engine limits as a result of this.

I agree. There are already many limitations to multiple engine vehicles, such as reduced fuel efficiency, and impossible skill requirements. Hardcode such a limit isn't elegant, and limits json power on this aspect.

alp7292 commented 1 year ago

i think there is a hidden debuff for 2 engine vehicles in game that causes 2 small-medium engine vehicle to have less power than same 1 engine vehicle it should also be removed or tweaked

randomtyper commented 1 year ago

Funnily enough, Smart Engine Controller part's manual states that Smart Controller supports from 2 to 5 controllable engines, despite player can only install two.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.