Spawns sealed food container with insufficient contents

[marimarigi]

Describe the bug

In low "Item spawn scaling factor" world, spawns sealed food containers with insufficient contents such as one canned tomato.

Attach save file

N/A

Steps to reproduce

1. Create a world with low "Item spawn scaling factor". (e.g. 0.10)
2. Start the game in that world.
3. Explore some houses, find sealed food containers.

Expected behavior

Either a sealed food containers with full contents is spawned or nothing is spawned.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3324 (22H2)
• Game Version: f2dedcb [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], No Rail Stations [No_Rail_Stations] ]

Additional context

Probably related to #60885. I think this is because the result of '"charges": X' is either 0 or X, but the result of '"count": X' is spread from 0 to X.

[mqrause]

The version right after yours has a fix for a bunch of related issues. I'm not sure how item spawn scaling is affecting all this, though, so would be great if you could test and reconfirm it with an updated version.

[marimarigi]

It also happens on version 2023-08-13-0522.

[SurFlurer]

/confirm I think I can figure out a fix for this.

[SurFlurer]

So there are two separate issues...

1. Cans will spill, so is_container_full() in seal() will falsely report that they are full.
2. Sealed itemgroups aren't placed monolithically, so low item spawn rate will make the game harder than it should be: nearly no container are to be spawned sealed, making shelf-stable food too rare.

[marimarigi]

2. Sealed itemgroups aren't placed monolithically, so low item spawn rate will make the game harder than it should be: nearly no container are to be spawned sealed, making shelf-stable food too rare.

Players with low spawn rate whould basically want it. Also, if players think it's too hard, they should readjust the rate.