CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

Pointless and cumbersome nesting of soft containers should be avoided #68341

Closed PatrikLundell closed 11 months ago

PatrikLundell commented 1 year ago

Describe the bug

When picking up multiple items in soft containers (such as e.g. plastic bags of salt) you typically end up with one container containing its original contents plus the rest of the containers containing the same thing.

This doesn't achieve anything since the containers are soft and thus no volume is saved, and it messes up the overview of what you're carrying since you now carry one soft container with mixed stuff. It also destroys sorting, as the mixed container ends up in the container zone rather than the zone where the containers would have ended up had they not been nested.

Attach save file

N/A

Steps to reproduce

  1. Raid a typical household and pick up the various spices that tend to be found together as a single action.
  2. End up with nested soft containers.
  3. Spend effort sorting it out or just have it all dumped in the container zone.

Expected behavior

Things should only be placed in containers if the action actually achieves something, such as using space in rigid containers or allowing things that otherwise would be too small to fit in the target pocket to be stored there.

Screenshots

No response

Versions and configuration

The code is an experimental with a hack to work around zombie and wreck pileups, but the issue is a long standing one.

Additional context

At least the nesting places all of the containers in a single one, rather than nesting it all the way down...

The removal of charges means you want to avoid picking up anything in double digit numbers out of a container like the plague, unless you absolutely have to (and only if taking the time isn't dangerous).

guo87995585 commented 1 year ago

I have abandoned the game due to meaningless non stackable items and endless nested containers

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.