Map extras do not evolve monsters

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.

http://cataclysmdda.org

Other

10.35k stars 4.15k forks source link

Map extras do not evolve monsters #68474

Open NetSysFire opened 1 year ago

NetSysFire commented 1 year ago

Describe the bug

Every other method of spawning them respects evolution.

Attach save file

n/a, see #68458 instead.

Steps to reproduce

Have a map extra spawning e.g civilians like my PR above.
Set the time to e.g 5 years.
Civilians still spawn in those map extras.

Expected behavior

They get evolved.

Screenshots

No response

Versions and configuration

OS: Linux
- OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
Game Version: d48717d [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Slowdown Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions] ]

Additional context

No response

ZhilkinSerg commented 1 year ago

I guess map extras should have optional start and end day fields.

NetSysFire commented 1 year ago

That would be pretty rad, too. But this is primarily about the monster spawn.

Procyonae commented 1 year ago

Commented a workaround I think works on the PR

Procyonae commented 10 months ago

I'd argue that manual placement of unevolved monsters should remain possible however this gets resolved

NetSysFire commented 10 months ago

Yeah, just apply evolution by default unless you specify evolve: false or something in the entry.

Procyonae commented 10 months ago

I'm also not sure this is exclusive to map extras but I haven't tested it

I-am-Erk commented 6 months ago

per discussion in discord, I would like to check: is it because of map extra behaviour, or because they are being placed as specific monsters by ID rather than part of a mongroup? Placing specific monsters --> not evolving would be intended behaviour, the solution then if you want a specific civilian would be to make a mongroup with just that civilian in it. Otherwise we're going to get some really annoying behaviour in other places where people have intentionally used the previous behaviour.