Bayonets add useless firing mode to guns

Terrorforge commented 1 year ago

Describe the bug

Adding a bayonet to a firearm allows you to select the bayonet as a firing mode in order to aim the reach attack.

However, as of #69201, bayonets no longer have reach attacks. As a result, the "bayonet" firing mode does nothing at all except clog up the firing mode menu.

Attach save file

Trivially reproducible

Steps to reproduce

Attach a bayonet to a gun
Switch firing mode to the bayonet
Attempt to fire the bayonet; note that nothing happens.

Expected behavior

No useless firing modes that just introduce clutter and confusion.

Screenshots

No response

Versions and configuration

OS: Windows
- OS Version: 10.0.19045.3570 (22H2)
Game Version: d39ddd6 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Mind Over Matter [mindovermatter], Bionic Slots [cbm_slots], Stats Through Kills [stats_through_kills] ]

Additional context

@tenmillimaster mentioned that they're planning to give some very long guns like the flintlock musket bayonets with reach attacks, so those particular examples would presumably need to keep the bayonet firing mode.

tenmillimaster commented 1 year ago

Ah heck.

tenmillimaster commented 1 year ago

Makeshift bayonet with firing mode (left unmodified)

Makeshfit bayonet with firing mode deleted (left unmodified)

The bayonets do not add any melee damage properties without the firemode defined. This will require some C++ to fix, I think.

tenmillimaster commented 12 months ago

I've gone and reconfirmed that this exists, that the firing mode is added and doesn't do much. However, this is the way the pistol bayonet used to work pre- #69201. I would like for melee gunmods to add their stats without adding a fire mode, but IMO this is more of a feature request and not a bug.

Terrorforge commented 12 months ago

Regardless of why it's there or how long it's existed, a gun having a firing mode that does literally nothing has to qualify as a bug.

tenmillimaster commented 12 months ago

I asked Kevin about it:

yes it's a good thing, no protest there, but it's not a bug

CleverRaven / Cataclysm-DDA