Inconsistencies in inventory compare window

[CoroNaut]

Describe the bug

The inventory compare window shows green/red text depending on which item is better/worse in that area. Some numbers are green on both sides, some are red on both sides. For instance, warmth/breathability is red on both, some bash and ballistic protections are both green, etc. Look at picture below and the expected behavior section here for all discrepancies. There may be some behind-the-scenes calculations that takes many factors into play for coloring each value. If so, it isn't clear what those could be.

Attach save file

N/A Trivially reproducible

Steps to reproduce

1. Get two items, my picture shows "light survivor boots" and "steeltoed sneakers" and compare
2. Notice that the coloring is wrong on some text.

Expected behavior

All specific examples of the problems in the image provided:

1. The light survivor boots don't have a length (not sure if this is a bug or intended)
2. Warmth for both items are red. I would expect the steeltoed sneakers to be green because it has +3 warmth vs the boots.
3. Breathability should be green for the sneakers. I expect that means that you are less likely to sweat at higher temperatures, less generated fatigue from using that body part, stuff like that. (I could be wrong as to how it specifically functions, but thats how I interpret it)
4. The "toes" bash protections for both items are green. I expect the higher value on the boots to be green, and sneakers to be red there.
5. The "foot" has both Bash and Ballistic values green for both items, I expect the boots to be better in both protections

If there are protections that one armor has that the compared item doesn't, like a helmet and boots, having head and feet protections, I would probably expect them to be default gray since they can not be compared in those ways.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
• Game Version: eca466b [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Slowdown Fungal Growth [no_fungal_growth], Stats Through Skills [StatsThroughSkills] ]

Additional context

No response

[Brambor]

I see "breathability" and "warmth". I don't know whether "breathability" is strictly positive, if not, I would expect them to be yellow, or a new colour. Same with "warmth".

If there are any other fields, please, describe what they are explicitly @CoroNaut

Edit: Oh, and the stats for foot bottoms should be all read on the right.

[Brambor]

And if I could I would move ankles on the right above toes or even above foot arches so that the body parts are mentioned in the same order.

Or split the (ankles, food arches, and heels) on the left to separate ankles. Then match it to the ankles on the right, but that would add text.

[CoroNaut]

I updated my report to be more descriptive of the fields that are both red or both green.

If the ankles, toes, foot arches are in the same order, that would be nice. I'm not certain how they are sorted, but perhaps they could be sorted by how many body parts they cover, and then by alphabetical order? Just a though.

As for splitting up sections, I think that would be a bad idea. It would add a bit of bloat to the window and be a little frustrating having to scroll too much. Given that some items have much longer descriptions or many more body parts that they protect when compared to another item, it may not be feasible to try to align them.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.