CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.32k stars 4.14k forks source link

Irradiation plant irradiates too much #70217

Open Holli-Git opened 9 months ago

Holli-Git commented 9 months ago

Describe the bug

You can chuck a lot of different food things through the plant and it'll come out irradiated despite the recipe for irradiating stuff not having it listed.

Attach save file

N/A

Steps to reproduce

  1. Put stuff thats not supposed to be irradiated in the red thing
  2. Irradiate it
  3. Enjoy irradiated commercial fertilizer

Expected behavior

I expect only things in the irradiation recipe to be irradiated. The list is https://github.com/ehughsbaird/Cataclysm-DDA/blob/c431c46b61579a5b4f0021fd8c74cfcd42bd42f6/data/json/itemgroups/Food/irradiated.json

Screenshots

image

Versions and configuration

Additional context

@ehughsbaird Please tell me if this is intended or not

ehughsbaird commented 9 months ago

This is not intended, and I can confirm it. I meant to revisit this, but https://github.com/CleverRaven/Cataclysm-DDA/pull/69630 was merged before I did.

CoroNaut commented 9 months ago

I found this cool article talking about irradiating foods on purpose: Food Irradiation. The difference between this form of irradiation meant to cleanse the food, and the form of irradiation that makes items deadly to handle might be worth specifying in the description of irradiated items.

For the deadly form of irradiation: [How does an ordinary object become radioactive?] I'm thinking the reason the irradiated objects in this facility would be deadly is from fragments and particles of radioactive elements landing on otherwise stable objects like food or commercial fertilizer. That link also talks about:

The people that were contaminated had been caught in the rain or walked in puddles. The rain took particles into their hair which lodged in the microtexture of the hairs themselves. These don't wash out easily and had to be cut out.

So I'm wondering if cutting your hair could reduce a tiny amount of radiation? That might be a bit too indepth for the game, but it gives a decent idea of why irradiated foods/items would be irradiated. Given this, "commercial fertilizer (irradiated)" might not even be a stretch.

Holli-Git commented 9 months ago

I found this cool article talking about irradiating foods on purpose: Food Irradiation. The difference between this form of irradiation meant to cleanse the food, and the form of irradiation that makes items deadly to handle might be worth specifying in the description of irradiated items.

For the deadly form of irradiation: [How does an ordinary object become radioactive?] I'm thinking the reason the irradiated objects in this facility would be deadly is from fragments and particles of radioactive elements landing on otherwise stable objects like food or commercial fertilizer. That link also talks about:

The people that were contaminated had been caught in the rain or walked in puddles. The rain took particles into their hair which lodged in the microtexture of the hairs themselves. These don't wash out easily and had to be cut out.

So I'm wondering if cutting your hair could reduce a tiny amount of radiation? That might be a bit too indepth for the game, but it gives a decent idea of why irradiated foods/items would be irradiated. Given this, "commercial fertilizer (irradiated)" might not even be a stretch.

I don't follow how this is related to the issue at hand

CoroNaut commented 9 months ago

Irradiated items will emit radiation if contaminated. If food is irradiated properly, it will be cleansed of some illnesses. If food is in an irradiation plant directly exposed to radioactive gasses and particles, it will actively emit small amounts of radiation. For items like commercial fertilizer, it can't really be "cleansed" of illness. However, it can be contaminated by radioactive fragments or particles and emit small amounts of radiation.

This is precisely what I mean when I say it may be worth specifying whether a food item is "cleansed" with radiation, or "contaminated" with radiation. Inedible items can only be "contaminated" with radiation. Contaminated items are covered with radioactive particles or fragments.

To relate specifically how this is related to the original issue post, "commercial fertilizer" is able to be contaminated with radiation, just not cleansed.

esotericist commented 9 months ago

marking confirmed based on ehughsbaird's comment

PatrikLundell commented 9 months ago

I would assume the irradiation plant still works as intended, in which case contamination from the radiation source should not happen (unless the player messes with it), and I don't think induced radiation is an issue with this type of radiation sources (i.e. the amount of induced radiation is insignificant compared to the natural background radiation).

CoroNaut commented 9 months ago

The irradiation plant works, and it cleanses food. There is another point to be made about the radioactive gasses. I would like to see the radioactive gasses not be there. They only serve to "contaminate" food. A radioactive gas would contain radioactive particles, which then land on everything. The proper irradiation of foods is done by sending a beam of radiation through the food, not sending it into a chamber with radioactive gasses just floating around and contaminating everything. I recommend looking at the link:

I found this cool article talking about irradiating foods on purpose: Food Irradiation.

for the proper process of irradiating foods. The irradiation plant would be broken if it was spewing radioactive gas everywhere. The radioactive gasses should probably pop out when you use the main computer to eject the radiation core.