Closed achpile closed 3 months ago
/confirmed, not sure it is worth to fix this values without proper review of most comestible rot time review
/confirmed, not sure it is worth to fix this values without proper review of most comestible rot time review
It was reviewed here I guess https://github.com/CleverRaven/Cataclysm-DDA/pull/23986 Where initial value of 1008 was added (this food was unspoilable befire this PR)
i mean yes, but it was made 5 years ago, we changed how we handle such stuff to a more reasonable approach, and jerky_human
doesn't even exist now
It's not your work, of course, just a thought
and jerky_human doesn't even exist now
Yes. Because the list is based on 25e35c9e1d84bd7e747ebb1611fcf90c0637dcd5 but my patch is based on current master branch.
List was just to show that every single "1008" value was converted in "24 hours", so it was like sed
or Replace all
and actually 24 is just "misspelled" 42 so it may just be a typo during values conversation :)
@Maleclypse sorry for wrong PR description format. Fixed that now.
Describe the bug
In this commit:
"spoils_in" was converted to string. And one particular value was converted wrong. For example:
1008 - it's "42 days", not 24
Items affected:
data/json/items/comestibles.json
data/json/items/comestibles/carnivore.json
There were added some more items after that commit like
salted_mollusk
- my guess is they "inherited" that issueAttach save file
N/A
Steps to reproduce
Expected behavior
I expect those items get spoiled in 42 days (1008 hours)
Screenshots
No response
Versions and configuration
master branch
Additional context
Sorry, I'm not familiar with PR system here, so here's an old-fashioned patch (for some reason github does not allow to attach it as a file)