CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

Glare inside of a closed garage #70344

Open Maleclypse opened 10 months ago

Maleclypse commented 10 months ago

Describe the bug

I was waiting in a garage hiding from a horde, when I noticed that at the end of my 30 minutes hiding it said The sunlight's glare makes it hard to see inside a closed and fully darkened garage.

Attach save file

Test Run 0.G-trimmed.tar.gz

Steps to reproduce

Open the save file see that I have waited and that I have experienced a glare in darkness. Perchance wait yourself and experience glare.

Expected behavior

No glare in darkness.

Screenshots

No response

Versions and configuration

Additional context

No response

GuardianDll commented 10 months ago

/confirmed image image

byfron commented 7 months ago

I've been looking into this, and looks like the floor of the garage is t_concrete and therefore is missing the FLAG_INDOORS that the outside_cache needs to detect what's indoors vs outdoors image

byfron commented 7 months ago

I may be wrong, but this is quite surprising, as any checks on indoor tiles will only depend on the tile type and not on the actual map structure (ceiling, walls, etc...). If this is still considered a bug, I suggest we update the glare check to make sure it can't happen in darkness or we update how the outdoor cache is built.