CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.07k stars 4.1k forks source link

Magiclysm enchanted weapons don't increase to-hit #70528

Open TaiGambol opened 7 months ago

TaiGambol commented 7 months ago

Describe the bug

Magiclysm +1/+2 enchantments on weapons are intended to increase the to-hit by an equivalent value, both according to the original PR implementing them and according to the current code; however, they do not currently do this.

Attach save file

Magiclysm Testing-trimmed.tar.gz

Steps to reproduce

  1. Create player in world with Magiclysm loaded.
  2. Spawn in National Guard Bayonet, Combat Knife +1, Combat Knife +2
  3. Observe that to-hit does not change between the three weapons.

Expected behavior

Weapons' to-hit scores should raise as their enchantment level raises.

Screenshots

image

Versions and configuration

Additional context

Would've tried to dig in and fix it myself, but I can't even begin to figure out what's actually causing the problem.

GuardianDll commented 7 months ago

relative field doesn't work with to_hit field, and there is no easy fix to this, not without some dose of a code, at least /confirm

TaiGambol commented 7 months ago

For what it's worth, I'm at least reasonably sure it used to work, but I can't pinpoint any timeframe in which it stopped working.