CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Character uses face to smash when not necessary #70565

Closed ANickelN closed 6 months ago

ANickelN commented 8 months ago

Describe the bug

Starting with the Hobo profession (and subsequently with the bindle equipped), you get the "You use your face to smash the object" text (and I'm assuming an accompanying malus) even after dropping it. Using weapons to smash things seems to work normally.

Attach save file

N/A I can provide a save file if nobody is able to replicate this issue.

Steps to reproduce

  1. Start with hobo profession.
  2. Drop bindle and attempt to smash nearby object.

Expected behavior

The text should reflect that my hands are no longer occupied.

Screenshots

image

Versions and configuration

Additional context

No response

Procyonae commented 8 months ago

Amusingly this isn't even the message for smashing something with your head, it's for smashing something with your eyes or mouth 😂

https://github.com/CleverRaven/Cataclysm-DDA/blob/d655083e9d2f4dd3dce16c125c80c940c7f9ca03/data/json/body_parts.json#L317 https://github.com/CleverRaven/Cataclysm-DDA/blob/d655083e9d2f4dd3dce16c125c80c940c7f9ca03/data/json/body_parts.json#L355

Maleclypse commented 8 months ago

It’s based on most armored part of your body.

ANickelN commented 8 months ago

It’s based on most armored part of your body.

Okay, my hands, feet and head were equally unarmored seeing as it is the hobo start. Why is the face chosen as the default hitting point of those three? Is it because of the scarf?

I can't find it in the code, is there a malus for hitting with your face instead of your hands/feet?

If there is: The selection doesn't make sense because it can prevent your character from escaping a situation he would otherwise be able to escape because he doesn't want to hurt his hands/feet.

If there isn't: Is there any reason the player would ever be hitting anything with their head if they weren't completely otherwise disabled? That seems like a great way to give yourself a concussion, and more something that a feral or zombie would do, not a human.

fairyarmadillo commented 8 months ago

A wolf or a bear mutant might conceivably bite an object to "smash" it, but I think we can safely remove the ability to use eyes/mouth to smash and if it's needed, re-add it in for fangs later, once they're integrated items.

RenechCDDA commented 8 months ago

Being able to smash with any body part was purposefully implemented as a move towards non-human body shapes, I don't think arbitrarily excluding body parts is the way to go. It should simply weight manipulation scores more heavily.

ANickelN commented 8 months ago

Being able to smash with any body part was purposefully implemented as a move towards non-human body shapes, I don't think arbitrarily excluding body parts is the way to go. It should simply weight manipulation scores more heavily.

Be as it may, it still seems strange that a baseline human would be smashing things with their face if they were given any other option.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.