CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.25k stars 4.11k forks source link

Vertically moving doesn't update effects #70644

Closed fairyarmadillo closed 6 months ago

fairyarmadillo commented 8 months ago

Describe the bug

Gutters have the UNSTABLE flag, which makes them apply the bouldering effect when you step onto them. This is also applied by downspouts, so when you step onto the downspout, you get the flag, and then when you climb up you keep it.

This doesn't happen if you climb up from a non-UNSTABLE tile, which you can do with adjacent furniture, corners, or other conditions. You will stand on the gutter above with no UNSTABLE listed, and can even wait there as long as you want and it won't pop up until you do.

Similarly, if you climb off a roof without using the downspout, you'll still have the bouldering effect even if you are stood on flat ground. The effect will not be removed until you take a step.

Attach save file

N/A

Steps to reproduce

Climb up on a roof without using the downspout, see that you do not get unstable footing even though you are supposed to.

Climb off a roof and see that you can keep the unstable footing debuff for hours even if you're just chilling on some grass.

I am guessing this is down to how our vertical movement is separate from our xy movement, and it's not checking the flags on the new tile you enter, at least as far as conditions from terrain flags are concerned.

Expected behavior

Unstable tiles should make you unstable when you step on them. Stable tiles should remove your unstable effect when you enter them.

Screenshots

No response

Versions and configuration

Additional context

No response

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.