CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.33k stars 4.14k forks source link

Add `SMALL_HIDER` flag to more monsters #71671

Closed NetSysFire closed 6 months ago

NetSysFire commented 8 months ago

Is your feature request related to a problem? Please describe.

66294 introduced said flag and @fairyarmadillo said in #71554 that many other monsters can use that flag.

Solution you would like.

Go through the small critters we have and add the SMALL_HIDER flag where appropriate. Two notable, already existing examples are cockroaches and cats.

This is a good first issue since it is trivial to resolve, it just requires adding a flag and determining where usage makes sense.

Describe alternatives you have considered.

No response

Additional context

No response

FlyingSpaceRhino commented 8 months ago

Similarly, I think the CORNERED_FIGHTER flag could be added to more creatures. And maybe there's some more furniture that could have the SMALL_HIDE flag added.

NetSysFire commented 8 months ago

CORNERED_FIGHER is a bit broken at the moment, see #67653.

But adding more furniture is great, too.

fairyarmadillo commented 8 months ago

CORNERED_FIGHER is a bit broken at the moment, see #67653.

But adding more furniture is great, too.

AFAIK it's not CORNERED_FIGHTER that's broken, it's that some animals, specifically black bears, don't have their morale set up correctly. Somebody tried to fix this in #67892 but ran into test issues. If someone adjusts the test values and reopens the PR, it'll be fixed.

The bear problem existed before CORNERED_FIGHTER, they would just stand there and let you beat on them until their morale got low enough to run, which usually meant they were almost dead.

munzaboss commented 7 months ago

Hello I am new and was wondering if I can do this Issue

marilynias commented 6 months ago

with #71767 merged, this issue should prob be closed