Open IdleSol opened 8 months ago
The pockets flag is for things with pockets that you could sensibly warm your hands in which isn't the case with either the wetsuit or spring suit as the pockets if they have any (I don't think they're standard more of a premium extra) are in awkward places like high on the chest or on the back. Spring suit appears to be a correct term and used in the US, steamer seems to be the correct couterpart name for the wetsuit we have but it doesn't appear to be used much in the US. I don't see any issue with changing spring suit to spring wetsuit though.
I looked at pictures of spring suit. I assume the "POCKETS" flag needs to be removed. Maybe the pockets themselves.
And I'd say it's worth checking the thickness and warmth. I think it's a good idea to increase it.
I don't see any issue with changing spring suit to spring wetsuit though.
I thought it was a mistake, so I suggested renaming it. But since "spring suit" is a normal name, I don't think it's worth it.
From my experience working with scuba retailers, I haven't seen any 3mm, 5mm, or 7mm thick wetsuits that had pockets, with the exception of a tiny pocket to hold your keys.
Typically, BCDs have several pockets and attachment points that divers use to manager their gear. (Think weights, surface marker buoy, dive knife/scissors, diving flashlight, marking line and reel, etc.)
Describe the bug
I noticed that the wetsuit did not warm my hands. A spring suit keeps warm my hands . Both have pockets. But only the spring suit has the “POCKETS” flag.
Where is the error and is it there?
Attach save file
N/A
Steps to reproduce
N/A
Expected behavior
N/A
Screenshots
No response
Versions and configuration
N/A
Additional context
https://cdda-guide.nornagon.net/item/wetsuit https://cdda-guide.nornagon.net/item/wetsuit_spring
I'm confused by the description of the pockets: Back pocket
https://github.com/CleverRaven/Cataclysm-DDA/blob/eb9cacd70e0a2b6ac996e9cf2d316c6f3ad339fd/data/json/items/armor/swimming.json#L763
https://github.com/CleverRaven/Cataclysm-DDA/blob/eb9cacd70e0a2b6ac996e9cf2d316c6f3ad339fd/data/json/items/armor/swimming.json#L1514
Other
If a flag is needed, then pay attention to:
other versions of wetsuits
**wetsuit** -https://cdda-guide.nornagon.net/item/xl_wetsuit -https://cdda-guide.nornagon.net/item/xs_wetsuit **thick wetsuit** -https://cdda-guide.nornagon.net/item/wetsuit_thick -https://cdda-guide.nornagon.net/item/xs_wetsuit_thick -https://cdda-guide.nornagon.net/item/xl_wetsuit_thick **Kevlar wetsuit** https://cdda-guide.nornagon.net/item/h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xs_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xl_h20survivor_jumpsuit **light Kevlar wetsuit oversuit** https://cdda-guide.nornagon.net/item/h20survivor_jumpsuit_light https://cdda-guide.nornagon.net/item/xs_h20survivor_jumpsuit_light https://cdda-guide.nornagon.net/item/xl_h20survivor_jumpsuit_light **thick Kevlar wetsuit** https://cdda-guide.nornagon.net/item/thick_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xs_thick_h20survivor_jumpsuit https://cdda-guide.nornagon.net/item/xl_thick_h20survivor_jumpsuit **wetsuit technical shorts** - https://cdda-guide.nornagon.net/item/wetsuit_shorts_technical - https://cdda-guide.nornagon.net/item/xs_wetsuit_shorts_technical - https://cdda-guide.nornagon.net/item/xl_wetsuit_shorts_technical - https://cdda-guide.nornagon.net/item/wetsuit_shorts_technical_loose - https://cdda-guide.nornagon.net/item/xs_wetsuit_shorts_technical_loose - https://cdda-guide.nornagon.net/item/xl_wetsuit_shorts_technical_loosePerhaps you should rename "spring suit" to "spring wetsuit"?
P.S. How did "spring suit" turn into "short wetsuit" when translated into Russian? This is a rhetorical question.