CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

NPC disassembly problem (2) #72265

Open watcherPlayer opened 7 months ago

watcherPlayer commented 7 months ago

Describe the bug

NPC disassembly problem #68805 (closed but problem not solved)

obtaining an absolutely whole thing from a disassembled one, of the same type, instead of component parts

Attach save file

DarkMagenta-trimmed.tar.gz

you have 2 NPCs for experiments and a lot of loot to disassemble

Steps to reproduce

1.start disassembling an item via ctrl + c, A, d using an NPC 2.interrupt the work of an NPC who is disassembling an item 3.start manufacturing an item ctrl + c, A, C with the help of an NPC by selecting the item to be disassembled 4.wait for the end

Expected behavior

the item should be disassembled into the item, and not into its entire copy

Screenshots

problem Снимок экрана от 2024-03-09 11-44-30 Снимок экрана от 2024-03-09 12-40-08 disassemble Снимок экрана от 2024-03-09 11-44-53 craft Снимок экрана от 2024-03-09 11-45-01 Снимок экрана от 2024-03-09 12-06-07

Versions and configuration

Additional context

who will handle this isuue, attach “NPC disassembly problem #68805” to this, because then there was no algorithm for reproducing the problem, thank you

watcherPlayer commented 7 months ago

if a damaged item is disassembled by a player, there is a return to the original item, up to the one from which the problems started, for example, I did this trick with disassembly 2 times, if I disassemble the player 2 times I will get the original item, this is something with inheritance and recursion ?...

Maybe there is an error with substituting object references? everything works fine with the player if the player continues to disassemble...

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

l29ah commented 2 months ago

/confirmed NPCs indeed continue already existing disassemblies by crafting them into the part itself, as of 52d2b5f44bf9ee4b61e0d7a6284d8ba1238b7076

Brambor commented 1 month ago

Don't name it:

NPC disassembly problem (2)

This tells nothing

Your description is a much better name:

obtaining an absolutely whole thing from a disassembled one, of the same type, instead of component parts