CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.18k forks source link

Add craftable iron anvil in innawood mod #72498

Closed pushard closed 5 months ago

pushard commented 7 months ago

Is your feature request related to a problem? Please describe.

I was playing innawood mod last year and now in a new run found, it is impossible to craft iron anvil any more :( only bronze is availble but I have no bronze. изображение

Solution you would like.

Make alternative way to craft iron anvil in innawood mod as it was before. I see no reason to craft iron anvil only from the crude anvil which is crafted from the railroad track as ancient people wasn't using any of railroad tracks :)

Describe alternatives you have considered.

Maybe add crude anvil in innawood mod, craftet from the 40 lumps of steel?

Additional context

No response

IdleSol commented 7 months ago

In my opinion. The best solution is to automatically learn the recipe for creating chunks of bronze. And switching to using bronze tools.

There are too many problems with creating a steel anvil.

https://github.com/CleverRaven/Cataclysm-DDA/issues/72208#issuecomment-2007075330

Bronze anvil Steel anvil

osuphobia commented 7 months ago

In my opinion. The best solution is to automatically learn the recipe for creating chunks of bronze. And switching to using bronze tools.

There are too many problems with creating a steel anvil.

On closer inspection, I would say that the blacksmith/redsmith system of dda has never been well-balanced, and perhaps due to misperception, some inappropriate changes were introduced lately.

A typical example is the bronze anvil. Back to 0.G, bronze anvil had Anvil 2, with a weight of roughly 5lbs. 5lbs is a weight of jewelers anvil, which, as its name suggests, is used by jeweler, silversmith, and watchmaker, not blacksmith.

The weight of bronze anvil was then modified to 26kgs, with its Anvil level raised to 3, to fit its usage intended. But I strongly doubt that a bronze anvil can aford any heavy work, as it is as brittle as crude cast iron. Leave it Anvil 2 is more reasonable, but on the other hand, most of the recipes requires Anvil 3, that would make bronze anvil a lame thing. As mentioned before, making it easier for low-spec tools and weapons to be made could be a better choice.

As for the recipe for creating chunks of bronze, the question is, do you think a random US high schooler would know the correct percent composition of bronze alloy? The components needed for chunk of bronze in dda are:

and IRL, lead, as well as silicon, manganese, etc, may also be a component in some type of bronze. If you cast a piece of bronze without planning, you may get a piece of "leaded brass" whose physical and chemical properties are quite different from the typical bronze you want. Therefore, learning the correct recipe from a book is not meaningless.

See also: https://www.anvilfire.com/21centbs/Selecting-an-Anvil.php https://www.gsa.gov/real-estate/historic-preservation/historic-preservation-policy-tools/preservation-tools-resources/technical-procedures/bronze-characteristics-uses-and-problems

One more thing: "Real" blacksmiths anvils mentioned in anvilfire, or the "london pattern" anvil exsits in dda, are all European things in the history. With a less Eurocentrism POV, you will realize that ancient people in the world had different type of anvils. Though adding variants to dda is another topic.

pushard commented 7 months ago

Yes you are right, just in innawood now it is impossible to craft steel anvil at all :(

IdleSol commented 7 months ago

@osuphobia

I don't know anything about blacksmiths. I'm not going to argue about the details.

But I do see a few problems. The main and most annoying (to me personally) problem, is not being able to make a set of tools, without books and the tools themselves.

The second problem, is the emphasis on realism. That's not a bad thing. If only it wasn't selective.

Consider a level 3 hammer. If we drop the realism, it could be made from a recipe for a homemade hammer. And that would solve a lot of problems.

But if we look from the point of view of realism, this hammer is not suitable (or suitable but with limitations) for blacksmithing. Because it is an ordinary hammer for hammering nails.

The solution is to make some assumptions. The simple option is that every schoolboy knows how to get bronze. (An alternative recipe with more material and time consumption). The more complex one, is to add new tools to break the reverse loops.

The right one, is to audit existing tools. To build a sequence of getting and fixing errors in recipes. But who's to say that this is first necessary (and will be accepted), and second, what exactly is an error and what is not?

IdleSol commented 7 months ago

@pushard

A temporary solution is to fix the file yourself:

/data/json/recipes/other/materials.json line 335

 {
    "result": "scrap_bronze",
    "type": "recipe",
...

    "batch_time_factors": [ 90, 4 ],
    "book_learn": [

to

    "batch_time_factors": [ 90, 4 ],
    "autolearn": true,
    "book_learn": [

This will give access to making chunks of bronze.

pushard commented 7 months ago

@IdleSol Thank you for this code, but I'm afraid it will not help me to craft steel anvil with anvil 3 :) in the Innawood, it is nearly impossible to survive without steel weapon/armor and guns near the Mi-go towers :( maybe you know how to add reciept for a steel anvil with just a lumps/chunks of steel as it was before?

osuphobia commented 7 months ago

@pushard

  {
    "type": "recipe",
    "activity_level": "MODERATE_EXERCISE",
    "result": "anvil",
    "id_suffix": "by_steel_chunk",
    "category": "CC_OTHER",
    "subcategory": "CSC_OTHER_TOOLS",
    "skill_used": "fabrication",
    "difficulty": 3,
    "time": "4 h",
    "autolearn": true,
    "qualities": [ { "id": "HAMMER", "level": 2 } ],
    "tools": [ [ [ "crucible", -1 ], [ "crucible_clay", -1 ] ], [ [ "forge", 150 ], [ "oxy_torch", 30 ] ] ],
    "proficiencies": [ { "proficiency": "prof_metalworking" }, { "proficiency": "prof_blacksmithing" } ],
    "components": [ [ [ "steel_chunk", 160 ], [ "steel_lump", 40 ], [ "frame", 4 ], [ "hdframe", 2 ] ] ]
  },

Add this to \data\json\recipes\recipe_others.json after the exisiting anvil recipe to get the old recipe.

pushard commented 7 months ago

@osuphobia thank you very much :)

NetSysFire commented 7 months ago

CC @Light-Wave

pushard commented 7 months ago

@osuphobia Hi, sorry for disturbing you, can you please point me where Hammer reciepe is? :) I've found that crafting a steel hammer require now Hammer lvl 3 tool :) I should play different game :(

IdleSol commented 7 months ago

data/json/recipes/tools/tools_hand.json

https://github.com/CleverRaven/Cataclysm-DDA/blob/54d9f4c977adbe9c5f564402cf6e384cc5d49724/data/json/recipes/tools/tools_hand.json#L304-L322

Make the changes

    "using": [ [ "blacksmithing_standard_XXX", 4 ], [ "steel_standard", 1 ] ],

data/json/requirements/toolsets.json

https://github.com/CleverRaven/Cataclysm-DDA/blob/54d9f4c977adbe9c5f564402cf6e384cc5d49724/data/json/requirements/toolsets.json#L94-L105

Add a new entry

  {
    "id": "blacksmithing_standard_XXX",
    "type": "requirement",
    "//": "Includes forging resources as well as tools needed for most blacksmithing. Per forging_standard energy cost balanced for one steel chunk.",
    "qualities": [ { "id": "ANVIL", "level": 3 }, { "id": "HAMMER", "level": 2 } ],
    "tools": [
      [ [ "forge", 20 ], [ "oxy_torch", 20 ] ],
      [ [ "metal_file_any", 1, "LIST" ] ],
      [ [ "metalworking_tongs_any", 1, "LIST" ] ]
    ]
  },
pushard commented 7 months ago

@IdleSol wow amazing! I got the idea :) Thank you!

PGR-14 commented 7 months ago

Oh yeah, relating to this, you can't make flatjaw tongs w/out flatjaw tongs (At least in the base game), so we should probably fix that

NetSysFire commented 7 months ago

Please make that a separate issue.

pushard commented 7 months ago

Oh yeah, relating to this, you can't make flatjaw tongs w/out flatjaw tongs (At least in the base game), so we should probably fix that

well I've found some cooper and tin wile exploring and craft flatjaws tongs the hard way. I mean getting ore for bronze was difficult in crates and I had to save/load some times because was falling hard :( anyway I agree, some iron/steel tools should be accesable in Innawood without the bronze.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.