CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.27k stars 4.12k forks source link

zone unload leaves auto whitelist container settings #73216

Open Killa3999 opened 4 months ago

Killa3999 commented 4 months ago

Describe the bug

Using zone unload zones to unload automatic whitelist containers doesn't remove the automatic whitelist

Attach save file

N/A

Steps to reproduce

  1. Get some auto whitelisted containers eg. pill bottles of different types of pills
  2. Unload said containers with an unload zone

Expected behavior

Said containers have their container settings cleared, so as to remove ui clutter when containers of the same type are mass unloaded using zone manager

Screenshots

image_2024-04-23_120842650

Versions and configuration

Additional context

No response

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

andrei8l commented 3 months ago

/confirmed item::on_contents_changed() is not called consistently when contents are removed. It can probably be called at a lower level, from visitable, instead of ad-hoc all over the place.