search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.73k stars 4.05k forks source link

Update description of mirror armor suits #73476

Closed XygenSS closed 1 week ago

XygenSS commented 2 weeks ago

Summary

None

Purpose of change

Originally the goal was to fix a typo in the tempered steel mirror armor description: Mirror armor is either round or square plates connected by fasteners to cover all four sides of the vital areas of the torso, mirror plate was usually worn on top of other armor like chainmail or brigandines. This set is made of intricate alternating circular and rectangular tempered steel *plated*, detailed on the outsides and polished to a mirrored sheen in the center. However seeing as the description is a bit awkward I decided to fix all of them.

Describe the solution

Update descriptions of five mirror armor variants.

Describe alternatives you've considered

These are proposed alternatives from the Discord:

by @Kamejeir : Mirror armor consists of daisy-chained plates made to help reinforce chainmail or brigandines by adding an extra layer ontop of the vitals.

by @mawranth : Mirror armor is either round or square plates connected by fasteners to cover the vital areas of the torso. Mirror plate was usually worn on top of other armour like chainmail or brigandines.

Other areas of consideration include cutting all fluff from descriptions. Making them plain and functional. Fully open to suggestions.

Testing

Additional context

github-actions[bot] commented 2 weeks ago

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand * Mirror armor earns its name from its distinct shape and polished sheen. Round and rectangular steel plates are fastened together to protect all four sides of the torso. It can be worn on top of other armor like chainmail and brigandines. Masterfully crafted with tempered steel, this set features a prominent circular plate on the front that has been polished to a **mirrorlike** sheen, flanked with supporting plates intricately joined to fit the body, all meticulously decorated. Will protect you from serious harm, as well as from the evil gazes of the undead.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary * If the word is normally in all lowercase, such as the noun `word` or the verb `does`, add it in its lower-case form; if the word is a proper noun, such as the surname `George`, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym `CDDA` or the unit `mW`, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence. * For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.