Termineitor244
commented
2 weeks ago Thanks for this! It was an oversight from my part that this pouch was so small, thanks!
Closed TheMurderUnicorn closed 1 week ago
Termineitor244
commented
2 weeks ago Thanks for this! It was an oversight from my part that this pouch was so small, thanks!
Summary
Bugfixes "Allow Ankle Wallet Pouch to Accommodate Larger Wallets"
Purpose of change
ankle_wallet_pouch was designed specifically to hold wallets, but could not hold ANY wallet that contained a standard 3 inch card (which is almost all cards), as the 3 inch card made the wallet too long for the pouch.
Describe the solution
Although I initially planned to change just the max_length, it became apparent that weight, length, and volume restrictions on the pocket needed to be increased. Here are the reasonings I wrote to myself while working on this:
Did not change wallets in any way
Item for testing – The Ankle Wallet Pouch, obviously, as the core item. For filling the pouch I used a large wallet, this is the largest wallet that should fit in the ankle wallet pouch, there are larger wallets but they are document cases that probably shouldn’t fit when this is designed for a standard wallet. Large wallet fit pouch when empty, but could not fit when filled with even a moderate amount of stuff or ANY 3 inch card.
Max Length – Large wallet stopped fitting in the pouch as soon as it was given any cards because its length was increased to 3 inches. FIX: Change ankle_wallet_pouch max_item_length to 9cm instead of 8cm, this allows it to accommodate wallets with cards.
Max Weight – ankle_wallet_pouch could accommodate 250g, which at first seemed reasonable until you realize a few wallets have coin pouches and coins add up to quite a bit of weight. After fully loading a Large wallet with tons of cash, cards, and coins I got it up to 1.75 lb or so (almost 800g). This is an unrealistic amount for the average person, especially given how little value coins have. So, I have changed this max_weight to 600g. The pocket needed a weight increase and 600g should accommodate most player situations and there’s no reason the pocket has to work for the most extreme situations like a wallet full of thousands of dollars of hub coins. I believe this little pouch could easily hold these 600g without bursting at the seams.
Max Volume – The fully loaded wallet came out to be about 560 ml, the pouches limit was 400ml. I’ve increased the pouch limit to 500 ml to somewhat accommodate filled wallets but not be so large that it allows for tons of nonwallet item storage. Slight increase, I think this pocket would be able to handle this.
Final Thoughts – While these increases will allow nonwallet items to be stored in the pouch, I don’t think this is a problem. The limitation of 9cm length on the pocket will prevent anything too silly from being stored here, and the weight limits and volume limits are also still quite small. I cannot prevent all nonwallets from being stored here, and realistically it’s just a pouch so why would it be restricted anyway, I can use the pocket to store whatever I want as long as it fits.
This should resolve the issue posted. This will still not accommodate the largest wallet that’s been filled literally to the brim, but I don’t think it needs to, I shouldn’t build it for the maximum most overloaded wallet possible, I should build it (as I have) to accommodate the majority of circumstances and still have limitations when you ‘ask too much’ of this little pocket. If this is wrong, please correct me and I will think about and amend the PR.
Hugely loaded wallet now fits, here is the final pocket data with my testing, this is more than enough to accommodate the average player situation, especially since most of us don’t collect coins, bills, or really anything beyond some cash cards and whatever ID cards we find.
Describe alternatives you've considered
None, really, once I sort of thought it through, this seems like the way to handle it. I laid out my reasonings above, and while I wasn't certain on the numbers themselves being perfect, it seems the pouch really did need at least some increase to all those values.
Testing
Pretty much just tested volume/weight/length of various wallet items to see how they inflated wallet size, tested them with the pouch, verified what was being limited/why, etc. Basic testing stuff.
Additional context
Closes #73477