search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.8k stars 4.08k forks source link

MOLLE pouches disappear from disassembled ballistic vest #73819

Open Hyperseeker opened 1 month ago

Hyperseeker commented 1 month ago

Describe the bug

Disassembling a ballistic vest or an LBV with MOLLE pouches attached to it makes the pouches disappear.

Attach save file

Orange Park Acres-trimmed.tar.gz

Steps to reproduce

  1. Spawn a PALS-capable item that can be disassembled into another PALS-capable item (e.g. heavy ballistic vest → US/SWAT ballistic vest + ballistic groin protector + 2 ballistic should protectors)
  2. Spawn a MOLLE pouch (e.g. triple stacker ammo pouch)
  3. Attach the pouch to the PALS-capable item
  4. Disassemble the PALS-capable item

Expected behavior

Either:

  1. The pouch would spawn along with the disassembled parts of the PALS-capable item
  2. The pouch would migrate to any of the disassembled parts of any of the parts can hold the pouch via PALS

Screenshots

No response

Versions and configuration

Additional context

This is valid for the latest (at the moment of testing) version of the 0.H candidate: https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/cdda-0.H-2024-05-15-0314

Presumably, this issue would also affect other PALS-capable items. This was discovered while modding, but the effects can be seen with only base-game items as well. Within the save, the error has been observed with a heavy ballistic vest and a load bearing vest with sling. (For what it's worth, I'd also failed to recover the sling from the latter, despite the item being newly-spawned.)

Migrating the pouch and its contents (if any of the disassembled parts support taking in MOLLE pouches) would be the ideal resolution, though I understand that this would be difficult to implement.

TealcOneill commented 1 month ago

Probably related to #61250

TealcOneill commented 4 weeks ago

/Confirm