CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.77k stars 4.07k forks source link

Dr. Prado doesn't always spawn w/ EMP grenades for the prototype robot Hub01 quest #73894

Open O1OOO1O opened 2 weeks ago

O1OOO1O commented 2 weeks ago

Describe the bug

Neither the EMP grenades, nor any of the armor the Intercom dialog mentions after the fact appeared on any corpse that was near the location of the robot. There was in fact no corpse near the robot. I deduced that from the blood stains and a zombie corpse (that I didn't kill) nearby, that the corpse must have risen as a zombie and then went to a prior save and verified that this can happen by re-triggering the quest.

Attach save file

Althea - Copy-trimmed.tar.gz

Steps to reproduce

Trigger the Prototype robot quest from Hub01 and go to the quest site. (don't need to kill the robot just long-range teleport to the quest location and evaluate the condition of the scientist corpse that spawns there. This does not always repro, I had to reload multiple times and go through multiple checks. If the body spawns as a corpse and stays a corpse, the EMP grenades and other items have always been present so far. If this occurs reload and re-trigger the quest and check again. If the body rises as a zombie and gets killed immediately by the robot, often getting knocked several tiles away) the labcoat w/ EMP grenades sometimes does not appear, and other Hub01 identifying gear may not appear or get added to the zombie's inventory/equipped items.

This might be getting caused by the No Hope mod which reduces items?

Expected behavior

Either the corpse does not rise as a zombie for quest dialog consistency, or if it does rise, all equipment intended to help aid in the completion of the quest remains intact and lootable from the zombie corpse.

Screenshots

No response

Versions and configuration

Additional context

No response

PGR-14 commented 2 weeks ago

It's no hope, it sometimes just forces important things to spawn, there should be a flag for No hope to spawn certain things

IdleSol commented 2 weeks ago

https://github.com/CleverRaven/Cataclysm-DDA/issues/71528#issuecomment-1949928128 This is a problem with the “Item Spawn Scaling Factor” setting and how the relevant things react with it.

For clarification. As I understand it, starting this quest causes the map to be generated: https://github.com/CleverRaven/Cataclysm-DDA/blob/968138b5e43e3b1e95bfce9c9a2b7153090c812d/data/json/npcs/robofac/robofac_intercom/robofac_intercom_missions.json#L231-L232

“Item Spawn Scaling Factor” interacts with the “chance” parameter by decreasing it, resulting in a decreased chance of items appearing from the group

https://github.com/CleverRaven/Cataclysm-DDA/blob/968138b5e43e3b1e95bfce9c9a2b7153090c812d/data/json/npcs/robofac/NC_ROBOFAC_SCIENTIST.json#L4

UPD. I can't find where the EMP grenade spawning was included. From memory they were, but I don't see them now.

I've gone completely blind: https://github.com/CleverRaven/Cataclysm-DDA/blob/968138b5e43e3b1e95bfce9c9a2b7153090c812d/data/json/npcs/robofac/NC_ROBOFAC_SCIENTIST.json#L11