CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.96k stars 4.08k forks source link

encumbrance_multiplier_always won't work at all #73906

Open Fl414r opened 1 month ago

Fl414r commented 1 month ago

Describe the bug

According to .json Shapeshifter supposed to reduce encumbrance by 60% on arms, hands, legs and mouth. But it just not work.

p.s. this part "encumbrance_multiplier_always": { "arm_l": 0.4, "arm_r": 0.4, "hand_l": 0.4, "hand_r": 0.4, "leg_l": 0.4, "leg_r": 0.4, "mouth": 0.4 }

Attach save file

test-trimmed.tar.gz

Steps to reproduce

1) Get Shapeshifter trait 2) Find out that it just not works

Expected behavior

Well, you know... Get my reduced encumbrance?

Screenshots

Screenshot_2024-05-18-16-52-59-276_com cleverraven cataclysmdda experimental Screenshot_2024-05-18-16-52-47-152_com cleverraven cataclysmdda experimental

Versions and configuration

Additional context

No response

GuardianDll commented 1 month ago

It supposed to change the encumbrance that is given by mutations, that apply encumbrance effects

Fl414r commented 1 month ago

It supposed to change the encumbrance that is given by mutations, that apply encumbrance effects

Really? Seems like I got confused by this one... Why it didn't named "encumbrance_mutations_multiplier" instead? If I use "encumbrance_always" I get myself clear encumbrance, so I expected same from multiplier version. Is there a effect that reduces/increases encumbrannce by n%?

Fl414r commented 1 month ago

It supposed to change the encumbrance that is given by mutations, that apply encumbrance effects

Really? Seems like I got confused by this one... Why it didn't named "encumbrance_mutations_multiplier" instead? If I use "encumbrance_always" I get myself clear encumbrance, so I expected same from multiplier version. Is there a effect that reduces/increases encumbrannce by n%?

Oh, wait. Tested it with Chitin, it still won't works.

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

GuardianDll commented 2 weeks ago

i suppose it works only for encumbrance, given by encumbrance_always and encumbrance_covered, field we do not use anymore in favor of integrated armor someone would probably need to rework it into something better