CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.32k stars 4.14k forks source link

[Sky Island] Crafting Alpha Secure Container on second character of same preset and name in world don't give container #73959

Closed Klamener closed 2 months ago

Klamener commented 4 months ago

Describe the bug

When crafting Alpha Secure Container on a second character in the world (first one took mission for alpha secure container but was deleted after that), created from the same preset and with same name as first one, with only start date changed, game throws errors and double-completes mission, but gives nothing to second character.

Attach save file

Mackenzie-trimmed.tar.gz

Steps to reproduce

1.Load a save 2.Try crafting Alpha Secure Container

Expected behavior

It should give me an Alpha Secure Container, attached to my body

Screenshots

1 2 3

Versions and configuration

Additional context

No response

Klamener commented 4 months ago

After testing on save with minimal mods, turned out that creating a character, taking starting missions, creating a second charater from same preset as first and crafting a container is enough to reproduce.

Test World1-trimmed.tar.gz

Standing-Storm commented 4 months ago

This is because the variables tracking your progress are all global variables, not character-specific, so when a second character in the same world checks the variable it's set to the "complete" state.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.