CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

Inconsistent behavior from undeployed Autonomous Surgical Scalpels CBM. #74094

Open MoonlitRiverlight opened 6 months ago

MoonlitRiverlight commented 6 months ago

Describe the bug

Attempting to cut/dissect/butcher something with the CBM scalpels undeployed and without another Fine Cutting source present reads as quality 5 fine cutting, but follows up with a failure message saying you have no tool with Fine Cutting. They are not displayed when undeployed for crafting purposes, they are displayed when deployed. They function properly if instead deployed as wielded item (as implemented in #39596). Having an item with Fine Cutting 1 or higher present while CBM is undeployed performs the dissection with Fine Cutting 5's stats.

Seems that #39589, #43211, and #64964 all relate/are this as well.

Attach save file

dEBUG-trimmed.tar.gz

Steps to reproduce

1.Load provided save. 2.Attempt to dissect human under PC (CBM undeployed), have error. 3.Fetch X-Acto Knife provided a bit to the left, beyond crafting range, attempt to dissect again, have FineCutting5's output. (Optionally quit midway for step 4 or reload the file.)

Optional for verification: 4.Deploy wielded CBM tool, be able to dissect with Fine Cutting 5.

Expected behavior

Either:

  1. Surgical Scalpels being unaccounted undeployed over all applications, to avoid false positives and inconsistencies.
  2. Tool qualities being present globally while undeployed (via discrete fakeitem?) so the autonomous scalpels don't require more effort by the player to use than carrying a common scalpel does.

Screenshots

No response

Versions and configuration

Additional context

39596 seems to be a partial answer to the issue, which would not be necessary if it got solved, but now that we do have the deployable weapon, no reason to take it out.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.