`The required items are not available to complete the %s at zone %s`

[Brambor]

Describe the bug

Trying to mine in the designed zone. I get a message explaining the failure with broken formatting:

Attach save file

Winter Beach-trimmed.tar.gz

Steps to reproduce

1. Load attached save.
2. O to open the Zone activity menu.
3. Mine area.
4. Observe the message log with the nondescriptive message ending in The required items are not available to complete the %s at zone %s

Expected behavior

The message formats correctly.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.4412 (22H2)
• Game Version: 0.G-9784-g96401952f5-dirty [64-bit] - master was 96401952f5
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

[Brambor]

It feels like the zone name is the unformatted sentence. In other words, it correctly formats the string but substitutes the second %s for a copy of the whole unformatted string.

[PatrikLundell]

The reason is probably that the parameters to you.add_msg_player_or_npc in activity_item_handling.cpp operation requirement_check_result are organized incorrectly. Looking at the profile it may be that the two strings should come first and their parameters should somehow be piled up into two trailing parameters. It could also be that the profile should be interpreted completely differently...