CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.96k stars 4.08k forks source link

Cannot refill vehicle mounted 200L Steel Drum with clean water #74524

Open ltngonnguyen opened 3 weeks ago

ltngonnguyen commented 3 weeks ago

Describe the bug

Cannot refill vehicle mounted 200L Steel Drum with clean water, even when I have clean water handy, it keeps saying

DEBUG : tried to put an item (water_clean, amount 1) in a container (55gal_drum) that cannot contain it

FUNCTION : int item::fill_with(const item&, int, bool, bool, bool, bool, Character*) FILE : src/item.cpp LINE : 12315 VERSION : cdda-experimental-2024-06-12-0454 fedfb57

Attach save file

Newhalem-trimmed.tar.gz

Steps to reproduce

  1. Fill a 200L Steel Drum with water
  2. Use a water purifier to purify it
  3. Drink a couple sips
  4. Install the drum in a vehicle
  5. Get some clean water
  6. Try to refill it using the [e]xamine menu on the vehicle

Expected behavior

The drum should be filled with the extra clean water

Screenshots

No response

Versions and configuration

Additional context

When I remove the drum and try to [i]nsert or [r]eload clean water with the drum on the ground, it said the mixing of different liquids is not allowed or something like that. The clean water I was trying to reload it with was from a supply drop crate and not water manually purified by me, if that helps.

PatrikLundell commented 3 weeks ago

Confirmed

The "Clean water" in the tank is somehow different from real "Clean water".

Could this be an issue with water gradually decaying over time? The overall UI thinks the various "kinds" of clean water is compatible with what's in the tank, but the refilling code somehow doesn't. The rejecting code is in the call chain from item.cpp operation item::fill_with().