CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.14k stars 4.1k forks source link

incorrect calculation of the amount of biogas when obtained from a pit #74569

Open watcherPlayer opened 2 months ago

watcherPlayer commented 2 months ago

Describe the bug

the amount of biogas obtained from processing fermentable fertilizer diverges between the value in the console and the value in inventory

Attach save file

DarkMagenta-trimmed.tar.gz

the pit is located on the right, plastic bottles are located in the cart

Steps to reproduce

  1. put a few plastic bottles in your inventory that can store gas
  2. examine a pit with preparing fertilizer
  3. get gas
  4. in my case, the console wrote that 1106 units of gas were received, and when I opened the inventory, I found 15 full plastic bottles of 500 each (for a total of 7500) (1106 != 7500 !!!!!)

Expected behavior

  1. suggest where to place the gas (now it is placed automatically in those containers that the game likes)
  2. calculate the value correctly

Screenshots

Снимок экрана от 2024-06-15 23-34-18 Снимок экрана от 2024-06-15 23-35-14

Versions and configuration

Additional context

No response

osuphobia commented 2 months ago

suggest where to place the gas (now it is placed automatically in those containers that the game likes)

73543 I have mentioned it before, will try to solve it later.

calculate the value correctly

One unit of biogas is not 1 charge, but 250 charges (250 mL). So you only gathered 30 units. For the two empty bottles, seems that they have item whitelist set and can not be filled by biogas.

watcherPlayer commented 2 months ago

thank you for the clarification

It would be nice then to show both those units of measurement so as not to mislead players and not produce such descriptions of bugs as I do

those bottles you are talking about are empty and sealed, these are sometimes found in the drop if they contained spoiled product that was lost due to spoilage, or these can be bought from traders (for example, the bartender in HUB01)

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.