CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.92k stars 4.08k forks source link

Magicalysm enchanted mace is based on regular mace instead of tempered mace #74611

Open Pbprovost opened 1 week ago

Pbprovost commented 1 week ago

Describe the bug

I believe this is an oversight, as the other enchanted weapons that have tempered versions are based on the tempered version.

Attach save file

N/A

Steps to reproduce

See https://github.com/CleverRaven/Cataclysm-DDA/blob/a9d18c82210265155f4324ff82b65a9bf971cef7/data/mods/Magiclysm/items/enchanted_melee.json#L229, https://github.com/CleverRaven/Cataclysm-DDA/blob/a9d18c82210265155f4324ff82b65a9bf971cef7/data/mods/Magiclysm/items/enchanted_melee.json#L237, and https://github.com/CleverRaven/Cataclysm-DDA/blob/a9d18c82210265155f4324ff82b65a9bf971cef7/data/mods/Magiclysm/recipes/enchanting.json#L356

These have "mace" as the recipe requirement and copy-from item, when they should be qt_mace.

Expected behavior

Going by the other enchanted items, it should be using the tempered variant.

Screenshots

No response

Versions and configuration

Current experimental.

Additional context

No response

Pbprovost commented 1 week ago

Actually, upon further review there are four other things that also aren't based on the tempered version.

I also see: kukri knife_trench knife_rambo battleaxe

Everything else with a tempered version looks to be based on it.