search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.92k stars 4.08k forks source link

Remove the MR73 #74636

Closed BalthazarArgall closed 6 days ago

BalthazarArgall commented 1 week ago

Summary

None

Purpose of change

While working on the Chiappa Rhino I noticed that the Manurhin MR73 was in the game, which is surprising given its rarity, after checking on gunbroker it turns out that not only is it rare but it's way below the inclusion standard.

Describe the solution

Migrate it and replace it with a similar revolver.

Describe alternatives you've considered

Testing

None.

Additional context

I can't access the completed listings due to not being a US citizen, maybe if you include them you meet the standards although I'd be surprised if it made much of a difference.

Gunbroker screenshot: Untitled

BalthazarArgall commented 1 week ago

Remind me to not work on 2 PRs touching the same files at the same time again

kevingranade commented 1 week ago

Here the hits for completed listings Screenshot_20240618_073853_Firefox , as expected...

Griffinhart commented 5 days ago

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and it can be purchased brand-new. They're not rare, they're just an expensive (~3700USD) niche (revolver) gun.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

KrunkySmokin commented 5 days ago

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and they can be purchased brand-new.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

BalthazarArgall commented 5 days ago

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and it can be purchased brand-new. They're not rare, they're just an expensive (~3700USD) niche (revolver) gun.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

Unless I'm misunderstanding this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

BalthazarArgall commented 5 days ago

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.) Beretta is the official US importer for the MR73 and they can be purchased brand-new. https://gun.deals/search/apachesolr_search/mr73 I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

Indeed the gun show is an excellent way to give players a way to access guns that both meet the requirements for inclusion and are rare. The issue with the MR73 is that it only meets one of those requirements.

harakka commented 5 days ago

Why are y'all looking up MR73s on Gunbroker?

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/GUN_NAMING_AND_INCLUSION.md

The comments of this already merged PR are not the place to debate this, if you have a better methodology make an issue explaining it.

KrunkySmokin commented 4 days ago

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.) Beretta is the official US importer for the MR73 and they can be purchased brand-new. https://gun.deals/search/apachesolr_search/mr73 I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

Indeed the gun show is an excellent way to give players a way to access guns that both meet the requirements for inclusion and are rare. The issue with the MR73 is that it only meets one of those requirements.

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

BalthazarArgall commented 4 days ago

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

Indeed. We already started removing some machineguns. As for your other point, I already addressed it:

[...]this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

KrunkySmokin commented 4 days ago

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

Indeed. We already started removing some machineguns. As for your other point, I already addressed it:

[...]this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

BalthazarArgall commented 4 days ago

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

KrunkySmokin commented 4 days ago

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

BalthazarArgall commented 4 days ago

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

That's because we make a distinction between "rare" and "too rare for inclusion".

Maleclypse commented 4 days ago

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

As mentioned above completed PRs are not the place to be discussing this. If you ignore requests to change the venue of a conversation again in the future it could result in removal of your ability to comment on this repo.