Remote controlling vehicles no longer works.

Void-Seeker commented 4 months ago

Describe the bug

Remote control (both normal for RC cars and for normal vehicles) immediately shows disconnect message after trying to control the vehicle.

Attach save file

Квойн-trimmed.tar.gz

Steps to reproduce

Spawn the vehicle outfitted with remote control system, use one from the provided save file, or spawn toy RC car model.
Obtain remote control for either vehicle or RC car. Character from the save already has one.
Try to remote control the car.

Expected behavior

Player is able to drive remotely controlled car.

Screenshots

No response

Versions and configuration

OS: Linux
- OS Version: Distributor ID: Linuxmint; Description: Linux Mint 21.2; Release: 21.2; Codename: victoria;
Game Version: cdda-experimental-2024-06-19-1635 5f78795 [64-bit]
Graphics Version: Tiles
Game Language: Русский (89,3%) [ru]
Mods loaded: [ Тёмные Дни Впереди [dda], Отключить потребности у НПС [no_npc_food], Портальные штормы игнорируют НПС [personal_portal_storms], Медленный рост фунгалоидов [no_fungal_growth], иконки видит-игрока, бег, приседание, кровотечение для retrodays [sees_player_retro], Характеристики за навыки [StatsThroughSkills], Характеристики за убийства [stats_through_kills], Скорость от ловкости [speedydex] ]

Additional context

No response

PatrikLundell commented 4 months ago

Failed to repeat.

A guess is that the reporter got confused by the limited indications provided. After taking control of the vehicle any movement commands are performed by the vehicle, not the PC. The only subtle indication of this being the case is the appearance of the speed indicator on the side bar.

Void-Seeker commented 4 months ago

I coundn't reproduce it on the new save too. And no, i didn't get confused by the output, i've used remote control before. It indeed just disconnects right after connecting, but for some reason only on this save on my machine. I don't know what's happening, tbh. I've tried to debug it myself on the new save with gdb, but it just works as intended there. Yet on my main installation both RC car and vehicle remote controlling are broken.

Void-Seeker commented 4 months ago

It kinda looks like some kind of desynchronisation, idk...

PatrikLundell commented 4 months ago

OS difference? Executable version difference? Library differences?

I don't know what could be desynchronized. As far as I know there's only a single game thread (fortunately, given the amount of trouble caused even without having to deal with synchronization of multiple thread and the associated vague symptoms of bugs).

deepvelocity commented 2 weeks ago

Can confirm, tested with the latest experimental and remotely controlling vehicles is not working (visually speed changes, fumes leave the muffler, but vehicle won't move). Tested with gas and electric engines. Result: remotely controlling vehicles is not possible on the latest experimental. Tried robot controls and drive by wire controls. Mods: Dark Days Ahead, Disable NPC needs, Portal Storms Ignore NPCs, Slowdown Fungal. (default stack)

Notes: vehicle target speed can be changed with remote controls, engine starts up and time waited actually counts. Vehicle is not attempting to reach the target speed, must mean some changes were made to that logic. Need more exploration, but I would recommend checking this PR https://github.com/CleverRaven/Cataclysm-DDA/pull/75467/files

CleverRaven / Cataclysm-DDA