constructing a standing tank with filled 60L tanks voids the contents

[deltanedas]

Describe the bug

if you make a standing tank in * it will be empty regardless of what the tanks had.

conversely if you deconstruct a tank that has liquids the 60L tanks you get are filled. so this is clearly a bug

its possible that the temperatures are slightly different and it cant handle that??

Attach save file

Deepstep-trimmed.tar.gz

Steps to reproduce

1. get 4 60L tanks with hot clean water, mostly full
2. make a standing tank
3. all your water is gone

Expected behavior

it should sum up the liquids (and average the temperature if different) since theyre the same liquid type, clean water

Screenshots

the tanks used

Versions and configuration

• OS: Linux
  • OS Version: LSB Version: 1.0; Distributor ID: VoidLinux; Description: Void Linux; Release: rolling; Codename: void;
• Game Version: cdda-experimental-2024-06-19-0447 551e1b5-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

[PatrikLundell]

I believe this has been reported before.

The reason is that the tank is just an item that's deleted from the world when the construction is finished, and nobody has written any code to deal with any potential contents (there is such code for crafting (by emptying the contents), but not for construction). Any logic to carry contained items over into a constructed furniture/terrain/appliance would have to deal with the issue of contents not accepted into the "pocket" of the new thing, as well as the case where it would require mixing of items.

Note that the above is not me saying things shouldn't be improved, just trying to explain why it is the way it currently is.

[deltanedas]

it might be possible to reuse the container emptying ui if that happens say i try make a tank using water and vinegar 60L tanks it first asks what liquid to store in the tank, then for every other liquid used brings up the transfer ui to move it somewhere else or dump it on the floor

[PatrikLundell]

It would probably have to be a copy rather than reuse due to how UI and code is intertwined like spaghetti, and you'd still have the same problem as crafting does when performed by a companion (but it would still be an improvement).

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.