Variant items aren’t targetable by missions

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.

http://cataclysmdda.org

Other

10.07k stars 4.09k forks source link

Variant items aren’t targetable by missions #75003

Open Maleclypse opened 1 month ago

Maleclypse commented 1 month ago

Describe the bug

If you use a specific variants ID in a mission goal tests will fail. Missions predate variant items so that explains potentially why.

Attach save file

N/A

Steps to reproduce

Open a PR with a mission targeting a variant item. Watch CI fail.

Expected behavior

Variant items to be supported.

Screenshots

No response

Versions and configuration

Current CI

Additional context

Need to link my PR currently failing to this issue but on phone right now.

PatrikLundell commented 1 month ago

Are you aiming at addressing it both ways? What I mean by that is:

Allow a mission to specify a specific variant (I don't see any case where this would be desirable, but I would guess such a case could come up, such a a T-shirt with a specific theme for a nerd. The refugee center has a teen who might want such a thing. Come to think of it, the sleaze bag's "special pants" could actually be a special variant).
The current case of asking for e.g. blankets and have it satisfied by any combination of the blanket item variants (but not, unfortunately, combinations of blanket versions, such as regular, down, and electric).

Maleclypse commented 1 month ago

So I spawned in 12 of the variantized sci-fi novels and could give them to Valzain for his broker mission no problem. But I didn’t have time to check a non broker mission.