CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Ectothermic does not increase speed, only cares about "official" temperature #75387

Open Terrorforge opened 1 month ago

Terrorforge commented 1 month ago

Describe the bug

According to the mutation's desription: "Your speed lowers or raises 1% for every 2 (1.1) degrees below or above 65 F (18.3 C)"

However, it doesn't actually raise your speed at higher temperatures. temperature_speed_mod just doesn't have that functionality, it can only change your speed below a certain temperature. Further, the rate of speed change is set to 0.5, not 1.

It also only seems to care about the abstract ambient temperature as determined by the weather, not the ambient temperature where the character actually is. You can be standing in a raging fire or freezing to death deep underground in an ice lab and in either case your character's speed is affected only by the average outdoor temperature at ground level. This is both patently unrealistic and really boring, as it leaves Ectothermic characters with no way to play around the trait, such as by setting and playing around fires, carrying heaters or investing in certain magical powers.

Attach save file

Trivially reproducible

Steps to reproduce

  1. Have Ectothermic
  2. Set fire
  3. do not get faster

Expected behavior

Ability does what it says, is affected by the actual temperature

Screenshots

image Temperature is 20C, character still has -6C

image Character is extremely hot, ambient temperature is 59C, still at -6 speed

image "Official" temperature is over 18C. Character suffers no penalties, but also gains no bonus.

image This character is in a frozen lab at -55C, but only has a -1 because on the surface it's noon in late summer.

Versions and configuration

Additional context

Xedra Evolved implements a version of this that actually increases speed in temperature_speed_mod_salamander

GuardianDll commented 1 month ago

It not increasing speed is intended behavior It not being affected by another temperatures is not

Terrorforge commented 1 month ago

If that's intended, then the whole mutation is redundant and needs to be removed or reworked, because it's currently identical to Cold-Blooded.

The ambient temperature thing probably affects all the Heat Dependant mutations, though.