CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.34k stars 4.14k forks source link

Milling Wild Rice Produces Incorrect Calorie Amount #75500

Open Arkentosh opened 2 months ago

Arkentosh commented 2 months ago

Describe the bug

Milling wild rice found in forests in a windmill produces dry rice with 0 kcal value. Not sure if grown wild rice does the same but I'm about to sleep and don't have the wakefulness to test rn.

Attach save file

NA

Steps to reproduce

Pick wild rice, dump into windmill, 0 kcal

Expected behavior

I assume they should have a 240 kcal value as per the hitchikers guide

Screenshots

No response

Versions and configuration

NA

Additional context

No response

PatrikLundell commented 2 months ago

Failed to repeat. Wild rice -> dry wild rice -> wheat free flour all have calories (although the last stage probably has far too many).

Note that you've not bothered to provide any of the information that would provide any grounds for proper fault finding:

Arkentosh commented 2 months ago

Apologies, as I said in the post I was exhausted and didn't have time to pull everything for a full report. I booted up a test save that's unmodded and it appears there is something wrong with my save in regards to the calorie counts, but that being said regardless the calorie count even on an unmodded save appears to be incorect. The wild rice is milling into dry which is only 24 calories per. Per the HHG the calorie count should be around 240. Even if we're assuming that 240 is being split amongst the 5 rice, which I'm not sure why it would be, the count is sitll incorrect regardless. Not sure if this has something to do with wild rice being only 90 kcal before it gets milled or if the 24 calories is intentional. However if it IS intentional that is uhh... Not at all a realistic amount of calories. Also worth noting that on debug menu the calorie counts match the HHG exactly Here's an image https://i.imgur.com/nWrrs7t.png And the game report for this debug save

PatrikLundell commented 2 months ago

The 120 kcalories in the wild rice is correctly split between the 5 dried wild rice as it should be, so that part is technically correct (this is if you spawn the wild rice: I don't know what the numbers will be if you process it with drying, threshing, etc. before that. Also, the spawning info claimed it would be 90 kcal, but examination if the spawned one showed 120). The weird thing is the splitting, as it should require 2 wild rice for 1 dried wild rice to match the corresponding rice calories. Now, that's only on the calorie front. I didn't look at the mass one, so other conditions might apply. Regardless, wild rice is weird to have the already "milled" dry wild rice being milled yet another time for a factor of 4 to yield wheat free flour.

Arkentosh commented 2 months ago

I did a grow using time pass in debug then threshed it etc and the calorie count was basically the same as the stuff you can find lying around in autumn. There's definitely something weird going on, and wild rice itself needs a little attention I'd say. If we're going by kcal to volume/kgs then the amount that is 1 dry wild rice should be around 220-240 kcal as it is on the HHG, given that that's about how much 70gs of rice is in calorie value on a cursory google search.

PatrikLundell commented 2 months ago

I don't actually know what "wild rice" is, but it seems to be a plant native to the area. If that's the case, I doubt it has a yield anywhere near cultivated rice given that the latter has been intensely bred for thousands of years, but it's possible the difference might be in volume rather than nutrient and/or calorie density of that yield (i.e. fewer/smaller grains).

Arkentosh commented 2 months ago

Wild rice is also called "indian rice", its' very much a real plant and has sustained north american native peoples for generations. Some cultures eat veeery heavy amounts of it, and it grows in abudance in certain areas of north america. It's called wild rice because it's actually very near identical to the white grain rice you can get at a store(calorically, I mean), except it's dark and much thicker/harder to cook down and longer. If you're curious here's the gov't page on it https://fdc.nal.usda.gov/fdc-app.html#/food-details/169726/nutrients. All in all about 70 grams of wild rice equates to approx 260 calories. So the calorie count in game is entirely wrong after it's milled, it should be worth around 10x what it is atm by weight. In all honesty wild rice feels a lot like the rest of the crop system, needing a ton of work/love. if I had the time I'd love to actually put a commit together for the entire crop system, and eventually the entire food industry/cooking systems in game altogether, but school is about to start up again and I don't think I have the time :/