CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.33k stars 4.14k forks source link

Maps do not override vague notions of what's on the overmap #75579

Closed Inglonias closed 1 month ago

Inglonias commented 2 months ago

Describe the bug

When using a map to determine what is around you, the details on the map are not used if you can currently see what is around you. Your character instead ignores the map

Attach save file

Apple-trimmed.tar.gz This save file has a character at the top of a radio tower with everything you need to reproduce the bug.

Steps to reproduce

  1. Make a player, ideally with a pair of binoculars.
  2. Climb a radio tower
  3. If there's a map up there, use it after looking around with the binoculars.

Expected behavior

I would expect that more specific information replaces the vagueness that my character can determine with dead reckoning.

Screenshots

image

This image was taken with the attached save file. Highlighted tiles were revealed by the survivors map I just used. Everything in the vision circle remains vague and unknown. Note how roads are not visible.

Versions and configuration

Additional context

Related to #75236 . Paging @ehughsbaird and @vetall812, as they worked in this area recently.

Terrorforge commented 2 months ago

I've also noticed this with other effects that reveal the map, such as science lab computers and mapping artifacts.

Those should definitely be able to update the map to geater detail as they typically represent eitger very accurate data or straight-up supernatural insight.

Inglonias commented 2 months ago

/confirmed

vetall812 commented 2 months ago

Tested and can confirm only the road issue. But view distance is increasing and I cant tell that it is bugged.

On the next screenshot you can see the view distance without binoculars: Red marks is the distance to outlines changes to vague. Vague distance here is about 2 tiles more: base_view_ruler

Next screenshot shows how roads appears on the unexplored area. You can see that there are no roads between red (outlines) and yellow (vague) marks: base+roads_rulers

Now I wear binoculars and my vague view distance increase drastically. (two yellow marks): vague_distance_increase

HOWEVER! If I use binoculars and THEN read the map roads wont appear in vague area: no_roads

Inglonias commented 2 months ago

To be specific, the desired behavior is that if you don't have perfect information on a tile already, activating a map that would reveal that tile should provide it, regardless of what its current revealed level is.

kevingranade commented 2 months ago

Rather, if a new source provides better information than what you already have it should improve it.

SurFlurer commented 1 month ago

Already fixed by #75641 ?

Inglonias commented 1 month ago

I'll take your word for it.