Magiclysm spellcasting menu is missing its category selector

[db48x]

Describe the bug

This menu was the only one in the game to use a uilist with categories, and now the code to implement the category selector has been removed.

The best way to fix this may be to have a unique implementation just for this menu, rather than to complicate the uilist further.

Attach save file

n/a

Steps to reproduce

Cast a spell in the Magiclsym mod.

Expected behavior

n/a

Screenshots

Versions and configuration

• OS: Linux
  • OS Version:
• Game Version: ad2c7edf6a-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Magiclysm [magiclysm], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

[PatrikLundell]

Dumbing down the functionality of support tools because it might be convenient for a change of implementation shouldn't be the first course of action. It may well be that whoever did this didn't think that functionality was used because the usage was hidden away in a mod.

[db48x]

It wasn’t done as the first course of action, it was done as a result of exhaustion.

[PatrikLundell]

Then it's even weirder. Knowingly break functionality for the time being because of being too tired to deal with it.

If it was known the functionality was used then the PR should have been kept on hold until a way to not break game functionality had been implemented.

[db48x]

Meh, the branch is called “experimental” for a reason. I presented the patch and accurately described the current state, including its known limitations. The developers committed it in spite of those limitations. If you don’t like it, take it up with them.