CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

The debug menu has a funny size #75667

Open db48x opened 1 month ago

db48x commented 1 month ago

Describe the bug

The primary debug menu has a lot of text at the top that causes problems when the code tries to pick a correct size for the menu. Currently it overrides the default sizing and sets itself to half the width and height of the screen. This looks awkward on normal screens but not half so awkward as it would otherwise. It looks even worse on small screens.

Attach save file

n/a

Steps to reproduce

Open the debug menu, you can’t miss it.

Expected behavior

I expect it to look so normal and ordinary that you don’t even notice it.

Screenshots

Screenshot 2024-08-14 at 10-38-56 uilist issues from migration #74341 · Issue #75661 · CleverRaven_Cataclysm-DDA

Small window: Screenshot 2024-08-14 at 10-44-35 uilist issues from migration #74341 · Issue #75661 · CleverRaven_Cataclysm-DDA

Versions and configuration

Additional context

No response

ZhilkinSerg commented 1 month ago

Removing debug.desired_bounds = { -1.0, -1.0, 0.5, 0.5 }; makes it look okayish:

image

ZhilkinSerg commented 1 month ago

Additionally removing flavor text makes it look nice:

image

db48x commented 1 month ago

Removing the override on the bounds is a simple enough patch. How does it look when the game window is small?

I don’t think we should remove the text; it does serve a purpose, and its removed automatically if you have a debug character. But maybe the first part, “Debug Functions”, should be a title instead. Then the text can be slightly shorter.

ZhilkinSerg commented 1 month ago

There is strange blue border appearing on third(?) key input, but it seems to affect all menus:

image

db48x commented 1 month ago

That’s known, not really that strange, happens when you wrap around from top to bottom or bottom to top, and is a separate issue.

ZhilkinSerg commented 1 month ago

image

image

db48x commented 1 month ago

Looks ok there, but what about a tall narrow window like a phone in portrait mode? Like in the original post.

CLIDragon commented 2 days ago

For reference, this is what it used to look like on a normal sized screen: image

And on a portrait mode screen: image

Same dimensions, just locked larger I suspect.