CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.3k stars 4.13k forks source link

Incendiary field burns fire immune player #75743

Open Terrorforge opened 1 month ago

Terrorforge commented 1 month ago

Describe the bug

The "incendiary" field generated by the military "incendiary grenade" burns the player regardless of any fireproofing. For example, the MoM power Flameshield makes you immune to every individual part of a fire, but does absolutely nothing to protect against the "incendiary" field. The same is true of the Thermal Dissipation CBM and conventionally fire-resistant armor like the activity suit.

I found the code that appears to be responsible for this on line 1747 in src/map_field.cpp, and the cause is clear; the incendiary does not actually deal heat damage or factor in heat resistance in any way. It just calls hurtall. There's a check specifically for the Mycus Fireproofing/Mycogenesis mutations, but those are the only forms of protection and even they only reduce the damage by half.

Attach save file

New Mind-trimmed.tar.gz Character has Flameshield active, is wearing an activity suit, and is holding an unactivated incendiary grenade.

Steps to reproduce

  1. Be fire immune
  2. Detonate an incendiary grenade where you're standing

Expected behavior

I'm not terribly familiar with real-life incendiaries, but it feels like no matter how nasty they are a character that's rendered immune to burning through magic or sci-fi supertech should still be immune to burning from direct contact with napalm or white phosphorous, and specifically fireproof gear like an entry suit should provide at least some protection. And at any rate this stuff isn't directly based on any real incendiary; the comment in map_field.cpp just refers to it as a "mysterious incendiary substance".

It should probably be reworked to use heat damage or something, but at the very least I think HEATSINK and maybe a heat armor check of some kind should be added alongside the Mycus mutations to the list of things that offer partial protection.

Screenshots

No response

Versions and configuration

Additional context

I don't think this counts a Flameshield failing to deliver on its promises yet again, but it's still pretty funny that I found yet another way the fire immunity powers does not, in fact, make you immune to fire.

kevingranade commented 1 month ago

Incindiaries are well above the cutoff for the heatsink effect/thernal dissapation, that part is working as intended. Dedicated firefighting gear should be somewhat resistant, but we're talking seconds of protection, not immunity.

Zireael07 commented 1 month ago

If I was the player here, I would expect the CBM and the MoM power to protect from ALL fire, i.e. be fire immune in the gaming sense.

If this is not what is intended, things should be explicitly reworded/called out in the descriptions

kevingranade commented 1 month ago

Reread the description.