CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.7k stars 4.2k forks source link

Scrolling in spellbook is not working properly likely since #74341 #75899

Open Keltas opened 3 months ago

Keltas commented 3 months ago

Describe the bug

If you have more spells than fits the window, when you scroll below the lowest visible spell, the highlight vanishes, rather than scrolling the spell list down. I believe it is likely to be caused by #74341 .

Attach save file

N/A

Steps to reproduce

  1. Learn enough spells to fill the window (around 33 should do the trick).
  2. Open spellbook.
  3. Scroll down using your preferred method (arrow keys/page down).
  4. Notice the highlight disappear as it selects a spell not visible on the screen.

Expected behavior

I expected the window to scroll down as you move the highlight down in order to keep it visible.

Screenshots

image

Versions and configuration

Additional context

No response

Keltas commented 3 months ago

Fixed in the newest experimental. Not sure which PR.

Keltas commented 1 month ago

Apparently rather than fixing the bug in some update I didn't notice, a scroll bar has appeared after gaining more spells seemingly "fixing" the issue. Even with the scroll bar there is still some wonkiness cutting the last spell from the screen. When having less spells the bug is still present.